----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28496/#review63276 -----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/DateTypeFunctions.java <https://reviews.apache.org/r/28496/#comment105434> Why we do need to create formatter when it is not used? Please take a look at this commit for the fix that I had made. It is returning milliseconds by mistake, so ignore that part. exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/DateTypeFunctions.java <https://reviews.apache.org/r/28496/#comment105435> Can we not just use the queryStartDate instead of creating a new date instance? exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/DateTypeFunctions.java <https://reviews.apache.org/r/28496/#comment105436> Curious to know how we will hit this case since we have an overloaded function that does not take any args. - Kannan Rajah On Nov. 27, 2014, 8:16 a.m., Venkata krishnan Sowrirajan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28496/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2014, 8:16 a.m.) > > > Review request for drill and Mehant Baid. > > > Repository: drill-git > > > Description > ------- > > Added functionality for unix_timestamp() similar to MySQL > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/DateTypeFunctions.java > f063466 > > exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestDateFunctions.java > 1ecae19 > > exec/java-exec/src/test/resources/functions/date/to_unixtimestamp_for_date.json > PRE-CREATION > > exec/java-exec/src/test/resources/functions/date/to_unixtimestamp_for_date_with_pattern.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/28496/diff/ > > > Testing > ------- > > Added testcases > > > Thanks, > > Venkata krishnan Sowrirajan > >
