----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28496/#review63485 -----------------------------------------------------------
Ship it! exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/DateTypeFunctions.java <https://reviews.apache.org/r/28496/#comment105753> Add space after , in the arg list. exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/DateTypeFunctions.java <https://reviews.apache.org/r/28496/#comment105754> Add space after , - Kannan Rajah On Dec. 2, 2014, 1:56 a.m., Venkata krishnan Sowrirajan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28496/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2014, 1:56 a.m.) > > > Review request for drill and Mehant Baid. > > > Repository: drill-git > > > Description > ------- > > Added functionality for unix_timestamp() similar to MySQL > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/DateTypeFunctions.java > f063466 > > exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestDateFunctions.java > 1ecae19 > > exec/java-exec/src/test/resources/functions/date/to_unixtimestamp_for_date.json > PRE-CREATION > > exec/java-exec/src/test/resources/functions/date/to_unixtimestamp_for_date_with_pattern.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/28496/diff/ > > > Testing > ------- > > Added testcases > > > Thanks, > > Venkata krishnan Sowrirajan > >
