Great thanks. We'll need to do a perf regression run as well. Should be neutral to positive but just want to check.
-- Jacques Nadeau CTO and Co-Founder, Dremio On Sat, Jul 25, 2015 at 8:45 PM, rahul challapalli < challapallira...@gmail.com> wrote: > The run with the last but one commit looks good! > > On Sat, Jul 25, 2015 at 7:49 PM, Jacques Nadeau <jacq...@dremio.com> > wrote: > > > Can you try again not including the last commit? (the one for 2941) > > On Jul 25, 2015 7:05 PM, "rahul challapalli" <challapallira...@gmail.com > > > > wrote: > > > > > Jacques, > > > > > > There are quite a few failures (91 execution and 52 timeouts). At a > > glance, > > > I have seen NPE's, IOOB erros and ChannelClosedException messages. I > > will > > > get back with more information tomorrow. > > > > > > - Rahul > > > > > > > > > > > > On Sat, Jul 25, 2015 at 5:54 PM, rahul challapalli < > > > challapallira...@gmail.com> wrote: > > > > > > > Jacques, > > > > > > > > I kicked off a run for functional testing. Will let you know if there > > are > > > > any regressions. > > > > > > > > - Rahul > > > > > > > > On Sat, Jul 25, 2015 at 5:07 PM, Jacques Nadeau <jacq...@apache.org> > > > > wrote: > > > > > > > >> I've been working on DRILL-2941 and DRILL-3242. Both are fairly > > > >> substantial changes. I've been running some regression and > > performance > > > >> tests and am getting pretty solid results. However, given their > > scale, > > > >> I'd > > > >> like to get someone else to take a second look from functional > > > regression > > > >> and performance regression testing to make sure these are a net > > benefit. > > > >> Does anyone have a few cycles to run my branches against some other > > > tests? > > > >> > > > >> The changes are at [1]. The commit id is: > > > >> 01d9f129be82a0bc2d90341ae80e7f78eb774942 > > > >> > > > >> Thanks, > > > >> Jacques > > > >> > > > >> [1] https://github.com/jacques-n/drill/tree/DRILL-2941 > > > >> > > > > > > > > > > > > > >
