Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/140#discussion_r38386206
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/BasicFormatMatcher.java
 ---
    @@ -72,7 +72,7 @@ public boolean supportDirectoryReads() {
     
       @Override
       public FormatSelection isReadable(DrillFileSystem fs, FileSelection 
selection) throws IOException {
    -    if (isReadable(fs, selection.getFirstPath(fs))) {
    +    if (isFileReadable(fs, selection.getFirstPath(fs))) {
    --- End diff --
    
    I think we need to check all of the selection for Drop, not just the first. 
 Otherwise we risk blowing away a directory which has a bunch of files, where 
only the first is readable.  Right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to