Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/140#discussion_r38386365
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java
 ---
    @@ -104,6 +107,9 @@ public WorkspaceSchemaFactory(DrillConfig drillConfig, 
FileSystemPlugin plugin,
           final FormatMatcher fallbackMatcher = new 
BasicFormatMatcher(formatPlugin,
               ImmutableList.of(Pattern.compile(".*")), 
ImmutableList.<MagicString>of());
           fileMatchers.add(fallbackMatcher);
    +      dropFileMatchers = fileMatchers.subList(0, fileMatchers.size() - 1);
    --- End diff --
    
    Why would we have different matchers for drop file.  Shouldn't we simply 
share the behavior across all matching behaviors?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to