> On Sept. 15, 2015, 2 a.m., Jacques Nadeau wrote: > > exec/java-exec/src/main/resources/rest/generic.ftl, line 59 > > <https://reviews.apache.org/r/38359/diff/2/?file=1072655#file1072655line59> > > > > You should leak authorization logic into the template. This should be > > constrained to the model. Along the following: > > > > boolean showStorage() > > boolean showOptions() > > boolean showLoginLogout()
That should say "You should not leak..." - Jacques ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38359/#review98978 ----------------------------------------------------------- On Sept. 14, 2015, 5:43 p.m., Venki Korukanti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38359/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2015, 5:43 p.m.) > > > Review request for drill, Jacques Nadeau and Jason Altekruse. > > > Repository: drill-git > > > Description > ------- > > Use jetty's SecurityHandler (with FormAuthenticator and LoginService) to > enforce authentication. Use jersey's annotations to enforece authorizations. > > > Diffs > ----- > > distribution/src/resources/drill-override-example.conf 805d6e9 > exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java > 0f6a5bb > > exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRestServer.java > 8c14587 > > exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java > 3e972b4 > > exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/LogOutServlet.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/MetricsResources.java > 28a292b > > exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/ModelWrapper.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/QueryResources.java > 145a476 > > exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/QueryWrapper.java > ee31929 > > exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/RestServerHelper.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/StatusResources.java > c99c49b > > exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/StorageResources.java > 49f387c > > exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/ThreadsResources.java > def5acb > > exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebUserSession.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/AnonymousAuthenticator.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/AnonymousLoginService.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/DrillRestLoginService.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/DrillUserPrincipal.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java > 6656bf6 > exec/java-exec/src/main/resources/drill-module.conf dbe449a > exec/java-exec/src/main/resources/rest/generic.ftl 9df2424 > exec/java-exec/src/main/resources/rest/index.ftl 99e9d8c > exec/java-exec/src/main/resources/rest/options.ftl 7ba1250 > exec/java-exec/src/main/resources/rest/profile/list.ftl cf92ede > exec/java-exec/src/main/resources/rest/profile/profile.ftl 47c7e06 > exec/java-exec/src/main/resources/rest/query/errorMessage.ftl dbdcc9e > exec/java-exec/src/main/resources/rest/query/result.ftl 7fe52a4 > exec/java-exec/src/main/resources/rest/static/img/apache-drill-logo.png > PRE-CREATION > exec/java-exec/src/main/resources/rest/static/login.html PRE-CREATION > exec/java-exec/src/main/resources/rest/status.ftl cafa523 > exec/java-exec/src/main/resources/rest/storage/list.ftl ef97561 > exec/java-exec/src/main/resources/rest/storage/update.ftl 2a276e1 > pom.xml c17e612 > > Diff: https://reviews.apache.org/r/38359/diff/ > > > Testing > ------- > > Currently testing is manual. Rest based unittests are coming in DRILL-2965. > > > Thanks, > > Venki Korukanti > >
