Github user adeneche commented on a diff in the pull request:
https://github.com/apache/drill/pull/159#discussion_r39799014
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SessionOptionManager.java
---
@@ -46,6 +47,33 @@ public SessionOptionManager(final OptionManager
systemOptions, final UserSession
}
@Override
+ public void deleteOption(final String name, final OptionValue.OptionType
type) {
+ if (type == OptionValue.OptionType.SESSION) {
+ try { // ensure option exists
+ SystemOptionManager.getValidator(name);
+ } catch (final IllegalArgumentException e) {
+ throw UserException.validationError()
+ .message(e.getMessage())
+ .build(logger);
+ }
+ options.remove(name);
+ shortLivedOptions.remove(name);
+ } else {
+ fallback.deleteOption(name, type);
+ }
+ }
+
+ @Override
+ public void deleteAllOptions(final OptionValue.OptionType type) {
+ if (type == OptionValue.OptionType.SESSION) {
+ options.clear();
+ shortLivedOptions.clear();
+ } else {
+ fallback.deleteAllOptions(type);
--- End diff --
same here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
