Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/159#discussion_r39984380
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/CompoundIdentifierConverter.java
---
@@ -107,7 +117,7 @@ public SqlNode visitChild(
}
SqlNode newOperand =
operand.accept(CompoundIdentifierConverter.this);
enableComplex = localEnableComplex;
- if (newOperand != operand) {
+ if (! newOperand.equalsDeep(operand, false)) {
--- End diff --
Is it necessary to call equalsDeep()? If the expression has an identifier
which is rewritten by CompoundIdentifierConverter, is it true that the new
expression would be different in reference from then original one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
