Github user jacques-n commented on a diff in the pull request:
https://github.com/apache/drill/pull/159#discussion_r40101415
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/CompoundIdentifierConverter.java
---
@@ -107,7 +117,7 @@ public SqlNode visitChild(
}
SqlNode newOperand =
operand.accept(CompoundIdentifierConverter.this);
enableComplex = localEnableComplex;
- if (newOperand != operand) {
+ if (! newOperand.equalsDeep(operand, false)) {
--- End diff --
I'm a little confused by this change. Operands are expected to be
immutable. As such, identity comparison should be sufficient. Are you trying to
avoid excessive rewrites?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
