Github user adeneche commented on a diff in the pull request:
https://github.com/apache/drill/pull/159#discussion_r40022994
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/testing/ExecutionControls.java
---
@@ -80,7 +80,7 @@
* @param ttl the number of queries for which this option should be
valid
*/
public ControlsOptionValidator(final String name, final String def,
final int ttl) {
- super(name, OptionValue.Kind.STRING,
OptionValue.createString(OptionType.SESSION, name, def));
+ super(name, OptionValue.Kind.STRING,
OptionValue.createString(OptionType.SYSTEM, name, def));
--- End diff --
Ok, I see, `TypeValidator` always expects _SYSTEM_ OptionValues
Should we add an assertion to TypeValidator to make sure this doesn't
happen again ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
