Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52953108
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/PersistentStoreProvider.java
---
@@ -17,17 +17,26 @@
*/
package org.apache.drill.exec.store.sys;
-import java.util.Map;
-
+import org.apache.drill.exec.exception.StoreException;
/**
- * Interface for reading and writing values to a persistent storage
provider. Iterators are guaranteed to be returned in key order.
- * @param <V>
+ * A factory used to create {@link PersistentStore store} instances.
+ *
*/
-public interface PStore<V> extends Iterable<Map.Entry<String, V>> {
- public V get(String key);
- public void put(String key, V value);
- public boolean putIfAbsent(String key, V value);
- public void delete(String key);
- public void close();
+public interface PersistentStoreProvider extends AutoCloseable {
+ /**
+ * Gets or creates a {@link PersistentStore persistent store} for the
given configuration.
+ *
+ * Note that implementors have liberty to cache previous {@link
PersistentStore store} instances.
+ *
+ * @param config store configuration
+ * @param <V> store value type
+ */
+ <V> PersistentStore<V> getStore(PersistentStoreConfig<V> config) throws
StoreException;
--- End diff --
getOrCreateStore(...)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
