Github user hnfgns commented on a diff in the pull request:

    https://github.com/apache/drill/pull/374#discussion_r52953875
  
    --- Diff: 
contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/config/HBasePersistentStore.java
 ---
    @@ -148,13 +154,13 @@ private void delete(byte[] row) {
         private Result current = null;
         private Result last = null;
         private boolean done = false;
    -    private int rowsRead = 0;
     
    -    Iter() {
    +    Iter(int take) {
           try {
             Scan scan = new Scan(tableNameStartKey, tableNameStopKey);
             scan.addColumn(FAMILY, QUALIFIER);
    -        scan.setCaching(config.getMaxIteratorSize() > 100 ? 100 : 
config.getMaxIteratorSize());
    +        scan.setCaching(Math.min(take, 100));
    --- End diff --
    
    nope. this patch introduces a way to paginate results via #getRange. this 
option is no longer needed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to