Okay we are down to the final one - DRILL-4482 - Avro no longer selects data correctly from a sub-structure.(Jason)
Note that MapR QA team is going to start testing 1.6 snapshot now before I roll out the release candidate. DRILL-4482 can be merged in later as it is not likely to affect the Hopefully there will be no show stoppers (. The plan is to roll out the release candidate by Thursday. Thanks Parth On Tue, Mar 8, 2016 at 9:31 AM, Parth Chandra <par...@apache.org> wrote: > OK, let's leave it out then. > > On Tue, Mar 8, 2016 at 9:25 AM, Jason Altekruse <altekruseja...@gmail.com> > wrote: > >> To be honest I was expecting a longer review cycle so I hadn't run the >> unit >> tests before posting it for review. There were only very minor functional >> changes, so I wasn't thinking it would be an issue, and I was anticipating >> having to update the patch before merging it. I could update the test that >> is failing but I don't see much sense in trying to get it into the release >> because it only introduces new tests and some small core refactoring. >> >> I'm all for getting it merged so everyone can start using it, I just think >> it doesn't really matter if it happens on the release branch or back on >> master once we cut a release branch. >> >> I would rather try to focus on getting the Avro issues resolved, which is >> what I'm working on right now. >> >> - Jason >> >> On Tue, Mar 8, 2016 at 8:58 AM, Parth Chandra <par...@apache.org> wrote: >> >> > Sounds good Jason. Let's finalize this in the hangout. >> > Do you have the expected plans for the failing tests? If so can you >> update >> > those and put in a pull request and we'll merge and run the tests. >> > Any reason for the operator test framework to be punted? You have a +1 >> to >> > merge it. >> > >> > >> > >> > On Mon, Mar 7, 2016 at 9:33 PM, Khurram Faraaz <kfar...@maprtech.com> >> > wrote: >> > >> > > We should update the expected results (i.e. the expected query plan in >> > this >> > > case) and not mark them as Failing. We do not have a Failing test >> > directory >> > > today. >> > > >> > > If we are sure the expected query plans for these tests are incorrect >> > > (today), we should go ahead and update the expected results files with >> > the >> > > correct query plans. >> > > >> > > Functional/ctas/ctas_auto_partition/existing_partition_ >> > > pruning/hierarchical/plan/count2_MD-185.q >> > > Functional/ctas/ctas_auto_partition/general/plan/drill3947_2.q >> > > Functional/ctas/ctas_auto_partition/general/plan/drill3947_4.q >> > > >> > > Thanks, >> > > Khurram >> > > >> > > On Tue, Mar 8, 2016 at 8:58 AM, Jason Altekruse < >> > altekruseja...@gmail.com> >> > > wrote: >> > > >> > > > The cutoff time sounds good to me. I don't think I'm too >> overburdened, >> > I >> > > > mostly tried putting together a merge branch today and had to kick a >> > few >> > > > things out as I found issues. >> > > > >> > > > As we are not running the full regression cluster at Dremio, it >> would >> > be >> > > > helpful if someone could merge Jacques patch (DRILL-4474) after >> running >> > > the >> > > > complete set of tests. Could someone at MapR pick up the test >> updates >> > and >> > > > merging this patch? >> > > > >> > > > These are the failures I was seeing so far, my fix was just going >> to be >> > > to >> > > > mark the tests as failing: >> > > > >> > > > >> > > >> > >> Functional/ctas/ctas_auto_partition/existing_partition_pruning/hierarchical/plan/count2_MD-185.q >> > > > Functional/ctas/ctas_auto_partition/general/plan/drill3947_2.q >> > > > Functional/ctas/ctas_auto_partition/general/plan/drill3947_4.q >> > > > >> > > > I will just go ahead and merge the other two fixes as I had a clean >> > unit >> > > > test run and neither of the patches will have any impact on the >> > > regression >> > > > tests. One is a build fix, that only changes behavior when running >> the >> > > > release profile and the other is a unit test fix. >> > > > >> > > > I had punted the operator unit tests out of the release, so those >> can >> > be >> > > > removed from your list. >> > > > >> > > > I will start looking back at both of the Avro issues right after >> > merging. >> > > > >> > > > On Mon, Mar 7, 2016 at 6:32 PM, Parth Chandra < >> pchan...@maprtech.com> >> > > > wrote: >> > > > >> > > > > The train is about to leave :). I'd like to propose a cutoff for >> > > > tomorrow 5 >> > > > > pm. >> > > > > (This will be a full week after the initial mail so plenty of time >> > for >> > > > > everyone to get their issues aired.) >> > > > > >> > > > > Here are the open items (that I am aware of) - >> > > > > >> > > > > Waiting to be merged >> > > > > DRILL-4483/pr 411 (Fix text plan regression in query profiles) >> > (Venki) >> > > > > DRILL-4437 (and others)/pr 394 (Operator unit test framework). >> > (Jason) >> > > > > DRILL-4332/pr 389 (Make vector comparison order stable in test >> > > framework) >> > > > > (?) >> > > > > DRILL-4474/pr 406 (Ensure that ConvertCountToDirectScan only >> pushes >> > > > through >> > > > > project when project is trivial.) - Tests need to be fixed (Jason) >> > > > > >> > > > > Need review - >> > > > > DRILL-4375/pr 402 (Fix the maven release profile) - (Jason - patch >> > > > > reviewed. Merge) >> > > > > DRILL-4486/pr 412 (Fix expression serialization escaping) (Need >> are >> > > > > reviewer) >> > > > > DRILL-4485 - Update MapR profile to use MapR 5.1.0 (Parth/Aditya) >> > > > > >> > > > > Regression >> > > > > DRILL-4482 - Avro no longer selects data correctly from a >> > > sub-structure. >> > > > No >> > > > > patch available. (Jason) >> > > > > >> > > > > Dropped >> > > > > DRILL-4372/pr 377(?) (Drill Operators and Functions should >> correctly >> > > > expose >> > > > > their types within Calcite.) Pushed out because of test failures >> > > > > >> > > > > Jason, at the moment it looks like you've volunteered for too >> much. >> > Can >> > > > we >> > > > > get other folks to help out? >> > > > > >> > > > > Thanks >> > > > > >> > > > > Parth >> > > > > >> > > > > >> > > > > On Mon, Mar 7, 2016 at 5:32 PM, Jason Altekruse < >> > > > altekruseja...@gmail.com> >> > > > > wrote: >> > > > > >> > > > > > 4474 is actually revealing a few invalid tests in the Regression >> > > suite >> > > > > that >> > > > > > test for the current incorrect plans. The fix should be >> included in >> > > the >> > > > > > release, but I will post a PR on the regression suite to update >> the >> > > > tests >> > > > > > before I push it. >> > > > > > >> > > > > > On Mon, Mar 7, 2016 at 4:44 PM, Steven Phillips < >> ste...@dremio.com >> > > >> > > > > wrote: >> > > > > > >> > > > > > > DRILL-4486 is a pretty simple fix. Without it, currently some >> > regex >> > > > > > queries >> > > > > > > will fail. >> > > > > > > >> > > > > > > I think we should include it in the release. >> > > > > > > >> > > > > > > >> > > > > > > https://github.com/apache/drill/pull/412 >> > > > > > > >> > > > > > > On Mon, Mar 7, 2016 at 2:15 PM, Jason Altekruse < >> > > > > > altekruseja...@gmail.com> >> > > > > > > wrote: >> > > > > > > >> > > > > > > > There is a small test issue with some of the refactoring >> that >> > > > > > accompanied >> > > > > > > > the operator unit tests. These don't change any user-facing >> > > > behavior, >> > > > > > so >> > > > > > > I >> > > > > > > > don't think it really needs to get into the release. I will >> be >> > > > > working >> > > > > > to >> > > > > > > > merge them into master after we cut the release branch. >> > > > > > > > >> > > > > > > > The change to update the avatica JDBC driver version also >> does >> > > not >> > > > > make >> > > > > > > any >> > > > > > > > behavior changes, so I think it also makes sense to keep it >> off >> > > the >> > > > > > > release >> > > > > > > > branch. >> > > > > > > > >> > > > > > > > I will be merging the fix for 4375 the maven release >> profile, >> > > 4474 >> > > > > > wrong >> > > > > > > > results with incorrect creation of DirectScan and 4332 >> fixing a >> > > > unit >> > > > > > test >> > > > > > > > to work in JDK 8, after another test run. >> > > > > > > > >> > > > > > > > On Mon, Mar 7, 2016 at 1:53 PM, Venki Korukanti < >> > > > > > > venki.koruka...@gmail.com >> > > > > > > > > >> > > > > > > > wrote: >> > > > > > > > >> > > > > > > > > WebUI profile issue: this is a regression cause by >> > refactoring >> > > of >> > > > > > > Calcite >> > > > > > > > > integration code (DRILL-4465) which sets the text plan >> only >> > if >> > > > > debug >> > > > > > is >> > > > > > > > > enabled. Will submit a patch soon. >> > > > > > > > > >> > > > > > > > > On Mon, Mar 7, 2016 at 1:29 PM, Sudheesh Katkam < >> > > > > > skat...@maprtech.com> >> > > > > > > > > wrote: >> > > > > > > > > >> > > > > > > > > > Thanks for clarifying Jacques. >> > > > > > > > > > >> > > > > > > > > > I haven’t looked into the fix for DRILL-4384; I >> reopened it >> > > > > because >> > > > > > > the >> > > > > > > > > > description mentioned “visualized plan” section is >> (also) >> > > > empty. >> > > > > > > > > > >> > > > > > > > > > Thank you, >> > > > > > > > > > Sudheesh >> > > > > > > > > > >> > > > > > > > > > > On Mar 7, 2016, at 1:08 PM, Jacques Nadeau < >> > > > jacq...@dremio.com >> > > > > > >> > > > > > > > wrote: >> > > > > > > > > > > >> > > > > > > > > > > The new bug (currently filed under DRILL-4384) is a >> > > > completely >> > > > > > > > > different >> > > > > > > > > > > bug than the original (original one has to do with >> > profile >> > > > > > metrics, >> > > > > > > > > this >> > > > > > > > > > > has to do with plan text). I try to look at it >> tonight if >> > > > noone >> > > > > > can >> > > > > > > > get >> > > > > > > > > > to >> > > > > > > > > > > it sooner. >> > > > > > > > > > > >> > > > > > > > > > > >> > > > > > > > > > > -- >> > > > > > > > > > > Jacques Nadeau >> > > > > > > > > > > CTO and Co-Founder, Dremio >> > > > > > > > > > > >> > > > > > > > > > > On Mon, Mar 7, 2016 at 12:37 PM, Parth Chandra < >> > > > > > > > pchan...@maprtech.com> >> > > > > > > > > > > wrote: >> > > > > > > > > > > >> > > > > > > > > > >> DRILL-4384 is a blocker for the release though >> > > > > > > > > > >> >> > > > > > > > > > >> On Mon, Mar 7, 2016 at 12:01 PM, Sudheesh Katkam < >> > > > > > > > > skat...@maprtech.com> >> > > > > > > > > > >> wrote: >> > > > > > > > > > >> >> > > > > > > > > > >>> I reopened DRILL-4384 < >> > > > > > > > > > https://issues.apache.org/jira/browse/DRILL-4384> >> > > > > > > > > > >>> (blocker); it is assigned to Jacques. >> > > > > > > > > > >>> >> > > > > > > > > > >>> On the latest master, the visualized and physical >> plan >> > > tabs >> > > > > on >> > > > > > > web >> > > > > > > > UI >> > > > > > > > > > are >> > > > > > > > > > >>> empty. >> > > > > > > > > > >>> >> > > > > > > > > > >>> Thank you, >> > > > > > > > > > >>> Sudheesh >> > > > > > > > > > >>> >> > > > > > > > > > >>>> On Mar 7, 2016, at 11:39 AM, Jason Altekruse < >> > > > > > > > > > altekruseja...@gmail.com >> > > > > > > > > > >>> >> > > > > > > > > > >>> wrote: >> > > > > > > > > > >>>> >> > > > > > > > > > >>>> I don't know if there are any specific time >> > constraints >> > > > for >> > > > > > > > getting >> > > > > > > > > > out >> > > > > > > > > > >>> the >> > > > > > > > > > >>>> release, but I'm inclined to go with Vicky on >> > > DRILL-4477, >> > > > at >> > > > > > > least >> > > > > > > > > > some >> > > > > > > > > > >>>> investigation into the scope of a fix would be >> good. I >> > > > think >> > > > > > > it's >> > > > > > > > > > >>>> reasonably big problem whether it's a regression or >> > not. >> > > > > > > > > > >>>> >> > > > > > > > > > >>>> On Mon, Mar 7, 2016 at 11:35 AM, Zelaine Fong < >> > > > > > > zf...@maprtech.com >> > > > > > > > > >> > > > > > > > > > >>> wrote: >> > > > > > > > > > >>>> >> > > > > > > > > > >>>>> Hakim, >> > > > > > > > > > >>>>> >> > > > > > > > > > >>>>> Yes, we'll include this in the release. >> > > > > > > > > > >>>>> >> > > > > > > > > > >>>>> -- Zelaine >> > > > > > > > > > >>>>> >> > > > > > > > > > >>>>> On Mon, Mar 7, 2016 at 9:31 AM, Abdel Hakim >> Deneche < >> > > > > > > > > > >>> adene...@maprtech.com >> > > > > > > > > > >>>>>> >> > > > > > > > > > >>>>> wrote: >> > > > > > > > > > >>>>> >> > > > > > > > > > >>>>>> If we still have time, I would like to include >> > > > DRILL-4457 >> > > > > > [1], >> > > > > > > > > it's >> > > > > > > > > > a >> > > > > > > > > > >>>>> wrong >> > > > > > > > > > >>>>>> results issue, I already have a fix and it's >> passing >> > > all >> > > > > > > tests, >> > > > > > > > I >> > > > > > > > > am >> > > > > > > > > > >>> just >> > > > > > > > > > >>>>>> waiting for a review [2] >> > > > > > > > > > >>>>>> >> > > > > > > > > > >>>>>> >> > > > > > > > > > >>>>>> [1] >> > https://issues.apache.org/jira/browse/DRILL-4457 >> > > > > > > > > > >>>>>> [2] https://github.com/apache/drill/pull/410 >> > > > > > > > > > >>>>>> >> > > > > > > > > > >>>>>> On Mon, Mar 7, 2016 at 4:50 PM, Parth Chandra < >> > > > > > > > par...@apache.org> >> > > > > > > > > > >>> wrote: >> > > > > > > > > > >>>>>> >> > > > > > > > > > >>>>>>> Hi guys, >> > > > > > > > > > >>>>>>> >> > > > > > > > > > >>>>>>> I'm still waiting for the following to be >> > > > reviewed/merged >> > > > > > by >> > > > > > > > > today. >> > > > > > > > > > >>>>>>> >> > > > > > > > > > >>>>>>> DRILL-4437 (and others)/pr 394 (Operator unit >> test >> > > > > > > framework). >> > > > > > > > > > >> Waiting >> > > > > > > > > > >>>>> to >> > > > > > > > > > >>>>>>> be merged (Jason) >> > > > > > > > > > >>>>>>> >> > > > > > > > > > >>>>>>> DRILL-4372/pr 377(?) (Drill Operators and >> Functions >> > > > > should >> > > > > > > > > > correctly >> > > > > > > > > > >>>>>> expose >> > > > > > > > > > >>>>>>> their types within Calcite.) - (Jinfeng to >> review) >> > > > > > > > > > >>>>>>> >> > > > > > > > > > >>>>>>> DRILL-4313/pr 396 (Improved client >> randomization. >> > > > Update >> > > > > > > JIRA >> > > > > > > > > with >> > > > > > > > > > >>>>>>> warnings about using the feature ) >> > > > (Hanifi/Sudheesh/Paul >> > > > > - >> > > > > > > > patch >> > > > > > > > > > >>>>>> reviewed. >> > > > > > > > > > >>>>>>> No +1) >> > > > > > > > > > >>>>>>> >> > > > > > > > > > >>>>>>> DRILL-4375/pr 402 (Fix the maven release >> profile) - >> > > > > (Jason >> > > > > > - >> > > > > > > > > patch >> > > > > > > > > > >>>>>>> reviewed. Ready to merge?) >> > > > > > > > > > >>>>>>> >> > > > > > > > > > >>>>>>> Thanks >> > > > > > > > > > >>>>>>> >> > > > > > > > > > >>>>>>> Parth >> > > > > > > > > > >>>>>>> >> > > > > > > > > > >>>>>>> On Sun, Mar 6, 2016 at 12:01 PM, Aditya < >> > > > > > > > adityakish...@gmail.com >> > > > > > > > > > >> > > > > > > > > > >>>>> wrote: >> > > > > > > > > > >>>>>>> >> > > > > > > > > > >>>>>>>> DRILL-4375/pr 402 - reviewed. >> > > > > > > > > > >>>>>>>> >> > > > > > > > > > >>>>>>>> On Sun, Mar 6, 2016 at 12:48 AM, Stefán Baxter >> < >> > > > > > > > > > >>>>>>> ste...@activitystream.com> >> > > > > > > > > > >>>>>>>> wrote: >> > > > > > > > > > >>>>>>>> >> > > > > > > > > > >>>>>>>>> Please review this and then consider as a >> > potential >> > > > > > > blocker: >> > > > > > > > > > >>>>>>>>> >> > > > > > > > > > >>>>>>>>> >> https://issues.apache.org/jira/browse/DRILL-4482 >> > > > > > > > > > >>>>>>>>> >> > > > > > > > > > >>>>>>>>> >> > > > > > > > > > >>>>>>>>> >> > > > > > > > > > >>>>>>>>> On Sat, Mar 5, 2016 at 3:15 AM, Parth Chandra >> < >> > > > > > > > > par...@apache.org >> > > > > > > > > > > >> > > > > > > > > > >>>>>>> wrote: >> > > > > > > > > > >>>>>>>>> >> > > > > > > > > > >>>>>>>>>> Okay here's the list of JIRA's pending. It >> > looks >> > > > > like >> > > > > > we >> > > > > > > > > need >> > > > > > > > > > >>>>> to >> > > > > > > > > > >>>>>>> get >> > > > > > > > > > >>>>>>>>> some >> > > > > > > > > > >>>>>>>>>> more time to get the PRs still under review >> > > merged, >> > > > so >> > > > > > > I'll >> > > > > > > > > wait >> > > > > > > > > > >>>>>> over >> > > > > > > > > > >>>>>>>> the >> > > > > > > > > > >>>>>>>>>> weekend. >> > > > > > > > > > >>>>>>>>>> It looks like the PRs that no reviewers >> assigned >> > > in >> > > > > the >> > > > > > > list >> > > > > > > > > > >>>>> below >> > > > > > > > > > >>>>>>> may >> > > > > > > > > > >>>>>>>>> not >> > > > > > > > > > >>>>>>>>>> make it into the release. >> > > > > > > > > > >>>>>>>>>> >> > > > > > > > > > >>>>>>>>>> Thanks >> > > > > > > > > > >>>>>>>>>> >> > > > > > > > > > >>>>>>>>>> >> > > > > > > > > > >>>>>>>>>> >> > > > > > > > > > >>>>>>>>>> Committed for 1.6 - >> > > > > > > > > > >>>>>>>>>> >> > > > > > > > > > >>>>>>>>>> DRILL-4384 - Query profile is missing >> important >> > > > > > > information >> > > > > > > > on >> > > > > > > > > > >>>>>> WebUi >> > > > > > > > > > >>>>>>> - >> > > > > > > > > > >>>>>>>>>> Merged >> > > > > > > > > > >>>>>>>>>> DRILL-3488/pr 388 (Java 1.8 support) - >> Merged. >> > > > > > > > > > >>>>>>>>>> DRILL-4410/pr 380 (listvector should >> initiatlize >> > > > > > bits...) >> > > > > > > - >> > > > > > > > > > >>>>> Merged >> > > > > > > > > > >>>>>>>>>> DRILL-4383/pr 375 (Allow custom configs for >> S3, >> > > > > > Kerberos, >> > > > > > > > > etc) - >> > > > > > > > > > >>>>>>> Merged >> > > > > > > > > > >>>>>>>>>> DRILL-4465/pr 401 (Simplify Calcite parsing & >> > > > planning >> > > > > > > > > > >>>>>> integration) - >> > > > > > > > > > >>>>>>>>>> Merged >> > > > > > > > > > >>>>>>>>>> DRILL-4467 - Baselines need updating. >> > > > > > > > > > >>>>>>>>>> DRILL-4449/pr 389 (Wrong results when >> metadata >> > > cache >> > > > > is >> > > > > > > > > used..) >> > > > > > > > > > >>>>>>> Merged >> > > > > > > > > > >>>>>>>>>> DRILL-4437 (and others)/pr 394 (Operator unit >> > test >> > > > > > > > framework). >> > > > > > > > > > >>>>>>> Waiting >> > > > > > > > > > >>>>>>>> to >> > > > > > > > > > >>>>>>>>>> be merged >> > > > > > > > > > >>>>>>>>>> DRILL-4449/pr 389 (Wrong results when >> metadata >> > > cache >> > > > > is >> > > > > > > > > used..) >> > > > > > > > > > - >> > > > > > > > > > >>>>>>>>> Waiting >> > > > > > > > > > >>>>>>>>>> to be merged >> > > > > > > > > > >>>>>>>>>> >> > > > > > > > > > >>>>>>>>>> Need review - >> > > > > > > > > > >>>>>>>>>> DRILL-4281/pr 400 (Drill should support >> inbound >> > > > > > > > impersonation) >> > > > > > > > > > >>>>>>> (Jacques >> > > > > > > > > > >>>>>>>>> to >> > > > > > > > > > >>>>>>>>>> review) >> > > > > > > > > > >>>>>>>>>> DRILL-4372/pr 377(?) (Drill Operators and >> > > Functions >> > > > > > should >> > > > > > > > > > >>>>>> correctly >> > > > > > > > > > >>>>>>>>> expose >> > > > > > > > > > >>>>>>>>>> their types within Calcite.) - (Jinfeng to >> > review) >> > > > > > > > > > >>>>>>>>>> DRILL-4313/pr 396 (Improved client >> > randomization. >> > > > > > Update >> > > > > > > > JIRA >> > > > > > > > > > >>>>> with >> > > > > > > > > > >>>>>>>>>> warnings about using the feature ) >> > > > > (Hanifi/Sudheesh/Paul >> > > > > > > to >> > > > > > > > > > >>>>>> review.) >> > > > > > > > > > >>>>>>>>>> DRILL-4375/pr 402 (Fix the maven release >> > profile) >> > > - >> > > > > > > (Aditya >> > > > > > > > to >> > > > > > > > > > >>>>>>> review) >> > > > > > > > > > >>>>>>>>>> >> > > > > > > > > > >>>>>>>>>> >> > > > > > > > > > >>>>>>>>>> >> > > > > > > > > > >>>>>>>>>> DRILL-4452/pr 395 (Update Avatica Driver to >> > latest >> > > > > > > Calcite) >> > > > > > > > > > >>>>>>>>>> DRILL-4332/pr 389 (Make vector comparison >> order >> > > > stable >> > > > > > in >> > > > > > > > test >> > > > > > > > > > >>>>>>>> framework) >> > > > > > > > > > >>>>>>>>>> DRILL-4411/pr 381 (hash join over-memory >> > > condition) >> > > > > > > > > > >>>>>>>>>> DRILL-4387/pr 379 (GroupScan should not use >> star >> > > > > column) >> > > > > > > > > > >>>>>>>>>> DRILL-4184/pr 372 (support variable length >> > decimal >> > > > > > fields >> > > > > > > in >> > > > > > > > > > >>>>>> parquet) >> > > > > > > > > > >>>>>>>>>> DRILL-4120 - dir0 does not work when the >> > directory >> > > > > > > structure >> > > > > > > > > > >>>>>> contains >> > > > > > > > > > >>>>>>>>> Avro >> > > > > > > > > > >>>>>>>>>> files - Partial patch available. >> > > > > > > > > > >>>>>>>>>> DRILL-4203/pr 341 (fix dates written into >> > parquet >> > > > > files >> > > > > > to >> > > > > > > > > > >>>>> conform >> > > > > > > > > > >>>>>> to >> > > > > > > > > > >>>>>>>>>> parquet format spec) >> > > > > > > > > > >>>>>>>>>> >> > > > > > > > > > >>>>>>>>>> >> > > > > > > > > > >>>>>>>>>> On Fri, Mar 4, 2016 at 6:24 PM, Jacques >> Nadeau < >> > > > > > > > > > >>>>> jacq...@dremio.com >> > > > > > > > > > >>>>>>> >> > > > > > > > > > >>>>>>>>> wrote: >> > > > > > > > > > >>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>> Awesome. Thanks Chun! >> > > > > > > > > > >>>>>>>>>>> On Mar 4, 2016 5:51 PM, "Chun Chang" < >> > > > > > > cch...@maprtech.com> >> > > > > > > > > > >>>>>> wrote: >> > > > > > > > > > >>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>> Jacques submitted a PR for fixing the >> failed >> > > > > > baselines. >> > > > > > > > I've >> > > > > > > > > > >>>>>>> merged >> > > > > > > > > > >>>>>>>>>> them >> > > > > > > > > > >>>>>>>>>>>> into automation master and confirmed the >> > failed >> > > > > tests >> > > > > > > are >> > > > > > > > > all >> > > > > > > > > > >>>>>>>> passing >> > > > > > > > > > >>>>>>>>>>> now. >> > > > > > > > > > >>>>>>>>>>>> Thanks. >> > > > > > > > > > >>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>> -Chun >> > > > > > > > > > >>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>> On Thu, Mar 3, 2016 at 10:48 PM, Jacques >> > Nadeau >> > > < >> > > > > > > > > > >>>>>>>> jacq...@dremio.com> >> > > > > > > > > > >>>>>>>>>>>> wrote: >> > > > > > > > > > >>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>> I think we need to include DRILL-4467 >> > > > > > > > > > >>>>>>>>>>>>> < >> > > > https://issues.apache.org/jira/browse/DRILL-4467 >> > > > > >. >> > > > > > I >> > > > > > > > > > >>>>> think >> > > > > > > > > > >>>>>> it >> > > > > > > > > > >>>>>>>> is >> > > > > > > > > > >>>>>>>>> a >> > > > > > > > > > >>>>>>>>>>> one >> > > > > > > > > > >>>>>>>>>>>>> line patch and it provides unpredictable >> > plans >> > > > at a >> > > > > > > > minimum >> > > > > > > > > > >>>>>> but >> > > > > > > > > > >>>>>>>> may >> > > > > > > > > > >>>>>>>>>>> also >> > > > > > > > > > >>>>>>>>>>>>> present invalid result. Still need to >> think >> > > > through >> > > > > > the >> > > > > > > > > > >>>>>> second >> > > > > > > > > > >>>>>>>>> half. >> > > > > > > > > > >>>>>>>>>>> I've >> > > > > > > > > > >>>>>>>>>>>>> seen this plan instability in some of my >> > recent >> > > > > test >> > > > > > > runs >> > > > > > > > > > >>>>>> (even >> > > > > > > > > > >>>>>>>>>> without >> > > > > > > > > > >>>>>>>>>>>>> Java 8) when running extended HBase tests. >> > > > > > > > > > >>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>> -- >> > > > > > > > > > >>>>>>>>>>>>> Jacques Nadeau >> > > > > > > > > > >>>>>>>>>>>>> CTO and Co-Founder, Dremio >> > > > > > > > > > >>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>> On Thu, Mar 3, 2016 at 10:02 PM, Parth >> > Chandra >> > > < >> > > > > > > > > > >>>>>>>> par...@apache.org> >> > > > > > > > > > >>>>>>>>>>>> wrote: >> > > > > > > > > > >>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>> Updated list (I'll follow up with the >> folks >> > > > named >> > > > > > > here >> > > > > > > > > > >>>>>>>>>> separately) - >> > > > > > > > > > >>>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>> Committed for 1.6 - >> > > > > > > > > > >>>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>> DRILL-4384 - Query profile is missing >> > > important >> > > > > > > > > > >>>>> information >> > > > > > > > > > >>>>>>> on >> > > > > > > > > > >>>>>>>>>> WebUi >> > > > > > > > > > >>>>>>>>>>> - >> > > > > > > > > > >>>>>>>>>>>>>> Merged >> > > > > > > > > > >>>>>>>>>>>>>> DRILL-3488/pr 388 (Java 1.8 support) - >> > Merged. >> > > > > > > > > > >>>>>>>>>>>>>> DRILL-4410/pr 380 (listvector should >> > > initiatlize >> > > > > > > > > > >>>>> bits...) - >> > > > > > > > > > >>>>>>>>> Merged >> > > > > > > > > > >>>>>>>>>>>>>> DRILL-4383/pr 375 (Allow custom configs >> for >> > > S3, >> > > > > > > > Kerberos, >> > > > > > > > > > >>>>>>> etc) >> > > > > > > > > > >>>>>>>> - >> > > > > > > > > > >>>>>>>>>>> Merged >> > > > > > > > > > >>>>>>>>>>>>>> DRILL-4465/pr 401 (Simplify Calcite >> parsing >> > & >> > > > > > planning >> > > > > > > > > > >>>>>>>>>> integration) - >> > > > > > > > > > >>>>>>>>>>>>>> Waiting to be merged >> > > > > > > > > > >>>>>>>>>>>>>> DRILL-4437 (and others)/pr 394 (Operator >> > unit >> > > > test >> > > > > > > > > > >>>>>>> framework). >> > > > > > > > > > >>>>>>>>>>> Waiting >> > > > > > > > > > >>>>>>>>>>>> to >> > > > > > > > > > >>>>>>>>>>>>>> be merged. >> > > > > > > > > > >>>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>> DRILL-4281/pr 400 (Drill should support >> > > inbound >> > > > > > > > > > >>>>>>> impersonation) >> > > > > > > > > > >>>>>>>>>>> (Jacques >> > > > > > > > > > >>>>>>>>>>>>> to >> > > > > > > > > > >>>>>>>>>>>>>> review) >> > > > > > > > > > >>>>>>>>>>>>>> DRILL-4372/pr 377(?) (Drill Operators and >> > > > > Functions >> > > > > > > > > > >>>>> should >> > > > > > > > > > >>>>>>>>>> correctly >> > > > > > > > > > >>>>>>>>>>>>> expose >> > > > > > > > > > >>>>>>>>>>>>>> their types within Calcite.) - Waiting >> for >> > > Aman >> > > > to >> > > > > > > > > > >>>>> review. >> > > > > > > > > > >>>>>>>>> (Owners: >> > > > > > > > > > >>>>>>>>>>>>> Hsuan, >> > > > > > > > > > >>>>>>>>>>>>>> Jinfeng, Aman, Sudheesh) >> > > > > > > > > > >>>>>>>>>>>>>> DRILL-4313/pr 396 (Improved client >> > > > randomization. >> > > > > > > > Update >> > > > > > > > > > >>>>>>> JIRA >> > > > > > > > > > >>>>>>>>> with >> > > > > > > > > > >>>>>>>>>>>>>> warnings about using the feature ) >> (Sudheesh >> > > to >> > > > > > > review.) >> > > > > > > > > > >>>>>>>>>>>>>> DRILL-4449/pr 389 (Wrong results when >> > metadata >> > > > > cache >> > > > > > > is >> > > > > > > > > > >>>>>>> used..) >> > > > > > > > > > >>>>>>>>>> (Aman >> > > > > > > > > > >>>>>>>>>>>> to >> > > > > > > > > > >>>>>>>>>>>>>> review) >> > > > > > > > > > >>>>>>>>>>>>>> DRILL-4069/pr 352 Enable RPC thread >> offload >> > by >> > > > > > default >> > > > > > > > > > >>>>>>> (Owner: >> > > > > > > > > > >>>>>>>>>>>> Sudheesh) >> > > > > > > > > > >>>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>> Need review - >> > > > > > > > > > >>>>>>>>>>>>>> DRILL-4375/pr 402 (Fix the maven release >> > > > profile) >> > > > > > > > > > >>>>>>>>>>>>>> DRILL-4452/pr 395 (Update Avatica Driver >> to >> > > > latest >> > > > > > > > > > >>>>> Calcite) >> > > > > > > > > > >>>>>>>>>>>>>> DRILL-4332/pr 389 (Make vector comparison >> > > order >> > > > > > stable >> > > > > > > > in >> > > > > > > > > > >>>>>>> test >> > > > > > > > > > >>>>>>>>>>>> framework) >> > > > > > > > > > >>>>>>>>>>>>>> DRILL-4411/pr 381 (hash join over-memory >> > > > > condition) >> > > > > > > > > > >>>>>>>>>>>>>> DRILL-4387/pr 379 (GroupScan should not >> use >> > > star >> > > > > > > column) >> > > > > > > > > > >>>>>>>>>>>>>> DRILL-4184/pr 372 (support variable >> length >> > > > decimal >> > > > > > > > fields >> > > > > > > > > > >>>>>> in >> > > > > > > > > > >>>>>>>>>> parquet) >> > > > > > > > > > >>>>>>>>>>>>>> DRILL-4120 - dir0 does not work when the >> > > > directory >> > > > > > > > > > >>>>>> structure >> > > > > > > > > > >>>>>>>>>> contains >> > > > > > > > > > >>>>>>>>>>>>> Avro >> > > > > > > > > > >>>>>>>>>>>>>> files - Partial patch available. >> > > > > > > > > > >>>>>>>>>>>>>> DRILL-4203/pr 341 (fix dates written into >> > > > parquet >> > > > > > > files >> > > > > > > > > > >>>>> to >> > > > > > > > > > >>>>>>>>> conform >> > > > > > > > > > >>>>>>>>>> to >> > > > > > > > > > >>>>>>>>>>>>>> parquet format spec) >> > > > > > > > > > >>>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>> Not included (yet) - >> > > > > > > > > > >>>>>>>>>>>>>> DRILL-3149 - No patch available >> > > > > > > > > > >>>>>>>>>>>>>> DRILL-4441 - IN operator does not work >> with >> > > Avro >> > > > > > > reader >> > > > > > > > - >> > > > > > > > > > >>>>>> No >> > > > > > > > > > >>>>>>>>> patch >> > > > > > > > > > >>>>>>>>>>>>>> available >> > > > > > > > > > >>>>>>>>>>>>>> DRILL-3745/pr 399 - Hive char support - >> New >> > > > > feature >> > > > > > - >> > > > > > > > > > >>>>> Needs >> > > > > > > > > > >>>>>>> QA >> > > > > > > > > > >>>>>>>> - >> > > > > > > > > > >>>>>>>>>> Not >> > > > > > > > > > >>>>>>>>>>>>>> included in 1.6 >> > > > > > > > > > >>>>>>>>>>>>>> DRILL-3623 - Limit 0 should avoid >> execution >> > > when >> > > > > > > > > > >>>>> querying a >> > > > > > > > > > >>>>>>>> known >> > > > > > > > > > >>>>>>>>>>>> schema. >> > > > > > > > > > >>>>>>>>>>>>>> (Need to add limitations of current >> impl). >> > > > > Intrusive >> > > > > > > > > > >>>>>> change; >> > > > > > > > > > >>>>>>>>> should >> > > > > > > > > > >>>>>>>>>>> be >> > > > > > > > > > >>>>>>>>>>>>>> included at beginning of release cycle. >> > > > > > > > > > >>>>>>>>>>>>>> DRILL-4416/pr 385 (quote path separator) >> > > (Owner: >> > > > > > > Hanifi) >> > > > > > > > > > >>>>> - >> > > > > > > > > > >>>>>>>> Causes >> > > > > > > > > > >>>>>>>>>>> leak. >> > > > > > > > > > >>>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>> Others - >> > > > > > > > > > >>>>>>>>>>>>>> DRILL-2517 - Already resolved. >> > > > > > > > > > >>>>>>>>>>>>>> DRILL-3688/pr 382 >> (skip.header.line.count in >> > > > > hive). >> > > > > > - >> > > > > > > > > > >>>>>> Already >> > > > > > > > > > >>>>>>>>>> merged. >> > > > > > > > > > >>>>>>>>>>>> PR >> > > > > > > > > > >>>>>>>>>>>>>> needs to be closed. >> > > > > > > > > > >>>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>> On Thu, Mar 3, 2016 at 9:44 PM, Parth >> > Chandra >> > > < >> > > > > > > > > > >>>>>>>> par...@apache.org >> > > > > > > > > > >>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>> wrote: >> > > > > > > > > > >>>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>>> Right. My mistake. Thanks, Jacques, for >> > > > > reviewing. >> > > > > > > > > > >>>>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>>> On Thu, Mar 3, 2016 at 9:08 PM, Zelaine >> > Fong >> > > < >> > > > > > > > > > >>>>>>>>> zf...@maprtech.com >> > > > > > > > > > >>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>> wrote: >> > > > > > > > > > >>>>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>>>> DRILL-4281/pr 400 (Drill should support >> > > > inbound >> > > > > > > > > > >>>>>>>> impersonation) >> > > > > > > > > > >>>>>>>>>>>>> (Sudheesh >> > > > > > > > > > >>>>>>>>>>>>>>>> to >> > > > > > > > > > >>>>>>>>>>>>>>>> review) >> > > > > > > > > > >>>>>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>>>> Sudheesh is the fixer of DRILL-4281, >> so I >> > > > don't >> > > > > > > think >> > > > > > > > > > >>>>> he >> > > > > > > > > > >>>>>>> can >> > > > > > > > > > >>>>>>>>> be >> > > > > > > > > > >>>>>>>>>>> the >> > > > > > > > > > >>>>>>>>>>>>>>>> reviewer :). >> > > > > > > > > > >>>>>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>>>> -- Zelaine >> > > > > > > > > > >>>>>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>>>> On Thu, Mar 3, 2016 at 6:30 PM, Parth >> > > Chandra >> > > > < >> > > > > > > > > > >>>>>>>>>> par...@apache.org> >> > > > > > > > > > >>>>>>>>>>>>>> wrote: >> > > > > > > > > > >>>>>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>>>>> Here's an updated list with names of >> > > > reviewers >> > > > > > > > > > >>>>> added. >> > > > > > > > > > >>>>>> If >> > > > > > > > > > >>>>>>>>>> anyone >> > > > > > > > > > >>>>>>>>>>>> else >> > > > > > > > > > >>>>>>>>>>>>>> is >> > > > > > > > > > >>>>>>>>>>>>>>>>> reviewing the open PRs please let me >> > know. >> > > > Some >> > > > > > PRs >> > > > > > > > > > >>>>>> have >> > > > > > > > > > >>>>>>>>>> owners >> > > > > > > > > > >>>>>>>>>>>>> names >> > > > > > > > > > >>>>>>>>>>>>>>>> that >> > > > > > > > > > >>>>>>>>>>>>>>>>> I will follow up with. >> > > > > > > > > > >>>>>>>>>>>>>>>>> Jason, I've included your JIRA in the >> > list. >> > > > > > > > > > >>>>>>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>>>>> Committed for 1.6 - >> > > > > > > > > > >>>>>>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>>>>> DRILL-4384 - Query profile is missing >> > > > important >> > > > > > > > > > >>>>>>>> information >> > > > > > > > > > >>>>>>>>> on >> > > > > > > > > > >>>>>>>>>>>>> WebUi - >> > > > > > > > > > >>>>>>>>>>>>>>>>> Merged >> > > > > > > > > > >>>>>>>>>>>>>>>>> DRILL-3488/pr 388 (Java 1.8 support) - >> > > > Merged. >> > > > > > > > > > >>>>>>>>>>>>>>>>> DRILL-4410/pr 380 (listvector should >> > > > > initiatlize >> > > > > > > > > > >>>>>>> bits...) >> > > > > > > > > > >>>>>>>> - >> > > > > > > > > > >>>>>>>>>>> Merged >> > > > > > > > > > >>>>>>>>>>>>>>>>> DRILL-4383/pr 375 (Allow custom >> configs >> > for >> > > > S3, >> > > > > > > > > > >>>>>>> Kerberos, >> > > > > > > > > > >>>>>>>>>> etc) - >> > > > > > > > > > >>>>>>>>>>>>>> Merged >> > > > > > > > > > >>>>>>>>>>>>>>>>> DRILL-4465/pr 401 (Simplify Calcite >> > > parsing & >> > > > > > > > > > >>>>> planning >> > > > > > > > > > >>>>>>>>>>>> integration) >> > > > > > > > > > >>>>>>>>>>>>> - >> > > > > > > > > > >>>>>>>>>>>>>>>>> Waiting to be merged >> > > > > > > > > > >>>>>>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>>>>> DRILL-4281/pr 400 (Drill should >> support >> > > > inbound >> > > > > > > > > > >>>>>>>>> impersonation) >> > > > > > > > > > >>>>>>>>>>>>>>>> (Sudheesh to >> > > > > > > > > > >>>>>>>>>>>>>>>>> review) >> > > > > > > > > > >>>>>>>>>>>>>>>>> DRILL-4372/pr 377(?) (Drill Operators >> and >> > > > > > Functions >> > > > > > > > > > >>>>>>> should >> > > > > > > > > > >>>>>>>>>>>> correctly >> > > > > > > > > > >>>>>>>>>>>>>>>> expose >> > > > > > > > > > >>>>>>>>>>>>>>>>> their types within Calcite.) - Waiting >> > for >> > > > Aman >> > > > > > to >> > > > > > > > > > >>>>>>> review. >> > > > > > > > > > >>>>>>>>>>>> (Owners: >> > > > > > > > > > >>>>>>>>>>>>>>>> Hsuan, >> > > > > > > > > > >>>>>>>>>>>>>>>>> Jinfeng, Aman, Sudheesh) >> > > > > > > > > > >>>>>>>>>>>>>>>>> DRILL-4313/pr 396 (Improved client >> > > > > > randomization. >> > > > > > > > > > >>>>>>> Update >> > > > > > > > > > >>>>>>>>> JIRA >> > > > > > > > > > >>>>>>>>>>>> with >> > > > > > > > > > >>>>>>>>>>>>>>>>> warnings about using the feature ) >> > > (Sudheesh >> > > > to >> > > > > > > > > > >>>>>> review.) >> > > > > > > > > > >>>>>>>>>>>>>>>>> DRILL-4437 (and others)/pr 394 >> (Operator >> > > unit >> > > > > > test >> > > > > > > > > > >>>>>>>>> framework). >> > > > > > > > > > >>>>>>>>>>>>> (Parth >> > > > > > > > > > >>>>>>>>>>>>>> to >> > > > > > > > > > >>>>>>>>>>>>>>>>> review) >> > > > > > > > > > >>>>>>>>>>>>>>>>> DRILL-4449/pr 389 (Wrong results when >> > > > metadata >> > > > > > > cache >> > > > > > > > > > >>>>>> is >> > > > > > > > > > >>>>>>>>>> used..) >> > > > > > > > > > >>>>>>>>>>>>> (Aman >> > > > > > > > > > >>>>>>>>>>>>>> to >> > > > > > > > > > >>>>>>>>>>>>>>>>> review) >> > > > > > > > > > >>>>>>>>>>>>>>>>> DRILL-4416/pr 385 (quote path >> separator) >> > > > > (Owner: >> > > > > > > > > > >>>>>> Hanifi) >> > > > > > > > > > >>>>>>>>>>>>>>>>> DRILL-4069/pr 352 Enable RPC thread >> > offload >> > > > by >> > > > > > > > > > >>>>> default >> > > > > > > > > > >>>>>>>>> (Owner: >> > > > > > > > > > >>>>>>>>>>>>>> Sudheesh) >> > > > > > > > > > >>>>>>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>>>>> Need review - >> > > > > > > > > > >>>>>>>>>>>>>>>>> DRILL-4375/pr 402 (Fix the maven >> release >> > > > > profile) >> > > > > > > > > > >>>>>>>>>>>>>>>>> DRILL-4452/pr 395 (Update Avatica >> Driver >> > to >> > > > > > latest >> > > > > > > > > > >>>>>>>> Calcite) >> > > > > > > > > > >>>>>>>>>>>>>>>>> DRILL-4332/pr 389 (Make vector >> comparison >> > > > order >> > > > > > > > > > >>>>> stable >> > > > > > > > > > >>>>>>> in >> > > > > > > > > > >>>>>>>>> test >> > > > > > > > > > >>>>>>>>>>>>>>>> framework) >> > > > > > > > > > >>>>>>>>>>>>>>>>> DRILL-4411/pr 381 (hash join >> over-memory >> > > > > > condition) >> > > > > > > > > > >>>>>>>>>>>>>>>>> DRILL-4387/pr 379 (GroupScan should >> not >> > use >> > > > > star >> > > > > > > > > > >>>>>> column) >> > > > > > > > > > >>>>>>>>>>>>>>>>> DRILL-4184/pr 372 (support variable >> > length >> > > > > > decimal >> > > > > > > > > > >>>>>>> fields >> > > > > > > > > > >>>>>>>> in >> > > > > > > > > > >>>>>>>>>>>>> parquet) >> > > > > > > > > > >>>>>>>>>>>>>>>>> DRILL-4120 - dir0 does not work when >> the >> > > > > > directory >> > > > > > > > > > >>>>>>>> structure >> > > > > > > > > > >>>>>>>>>>>>> contains >> > > > > > > > > > >>>>>>>>>>>>>>>> Avro >> > > > > > > > > > >>>>>>>>>>>>>>>>> files - Partial patch available. >> > > > > > > > > > >>>>>>>>>>>>>>>>> DRILL-4203/pr 341 (fix dates written >> into >> > > > > parquet >> > > > > > > > > > >>>>>> files >> > > > > > > > > > >>>>>>> to >> > > > > > > > > > >>>>>>>>>>> conform >> > > > > > > > > > >>>>>>>>>>>>> to >> > > > > > > > > > >>>>>>>>>>>>>>>>> parquet format spec) >> > > > > > > > > > >>>>>>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>>>>> Not included (yet) - >> > > > > > > > > > >>>>>>>>>>>>>>>>> DRILL-3149 - No patch available >> > > > > > > > > > >>>>>>>>>>>>>>>>> DRILL-4441 - IN operator does not work >> > with >> > > > > Avro >> > > > > > > > > > >>>>>> reader >> > > > > > > > > > >>>>>>> - >> > > > > > > > > > >>>>>>>> No >> > > > > > > > > > >>>>>>>>>>> patch >> > > > > > > > > > >>>>>>>>>>>>>>>>> available >> > > > > > > > > > >>>>>>>>>>>>>>>>> DRILL-3745/pr 399 - Hive char support >> - >> > New >> > > > > > feature >> > > > > > > > > > >>>>> - >> > > > > > > > > > >>>>>>>> Needs >> > > > > > > > > > >>>>>>>>>> QA - >> > > > > > > > > > >>>>>>>>>>>> Not >> > > > > > > > > > >>>>>>>>>>>>>>>>> included in 1.6 >> > > > > > > > > > >>>>>>>>>>>>>>>>> DRILL-3623 - Limit 0 should avoid >> > execution >> > > > > when >> > > > > > > > > > >>>>>>> querying >> > > > > > > > > > >>>>>>>> a >> > > > > > > > > > >>>>>>>>>>> known >> > > > > > > > > > >>>>>>>>>>>>>>>> schema. >> > > > > > > > > > >>>>>>>>>>>>>>>>> (Need to add limitations of current >> > impl). >> > > > > > > Intrusive >> > > > > > > > > > >>>>>>>> change; >> > > > > > > > > > >>>>>>>>>>>> should >> > > > > > > > > > >>>>>>>>>>>>> be >> > > > > > > > > > >>>>>>>>>>>>>>>>> included at beginning of release >> cycle. >> > > > > > > > > > >>>>>>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>>>>> Others - >> > > > > > > > > > >>>>>>>>>>>>>>>>> DRILL-2517 - Already resolved. >> > > > > > > > > > >>>>>>>>>>>>>>>>> DRILL-3688/pr 382 >> (skip.header.line.count >> > > in >> > > > > > hive). >> > > > > > > > > > >>>>> - >> > > > > > > > > > >>>>>>>>> Already >> > > > > > > > > > >>>>>>>>>>>>> merged. >> > > > > > > > > > >>>>>>>>>>>>>> PR >> > > > > > > > > > >>>>>>>>>>>>>>>>> needs to be closed. >> > > > > > > > > > >>>>>>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>>>>> Thanks >> > > > > > > > > > >>>>>>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>>>>> Parth >> > > > > > > > > > >>>>>>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>>>>> On Thu, Mar 3, 2016 at 3:21 PM, Jason >> > > > > Altekruse < >> > > > > > > > > > >>>>>>>>>>>>>>>> altekruseja...@gmail.com> >> > > > > > > > > > >>>>>>>>>>>>>>>>> wrote: >> > > > > > > > > > >>>>>>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>>>>>> I have updated the PR for the parquet >> > date >> > > > > > > > > > >>>>>> corruption >> > > > > > > > > > >>>>>>>>> issue >> > > > > > > > > > >>>>>>>>>>> that >> > > > > > > > > > >>>>>>>>>>>>>>>> didn't >> > > > > > > > > > >>>>>>>>>>>>>>>>>> make it into 1.5. >> > > > > > > > > > >>>>>>>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>>>>>> >> > https://github.com/apache/drill/pull/341 >> > > > > > > > > > >>>>>>>>>>>>>>>>>> >> > > > > > https://issues.apache.org/jira/browse/DRILL-4203 >> > > > > > > > > > >>>>>>>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>>>>>> If this can get reviewed, I think it >> > would >> > > > be >> > > > > > good >> > > > > > > > > > >>>>>> to >> > > > > > > > > > >>>>>>>> get >> > > > > > > > > > >>>>>>>>>> into >> > > > > > > > > > >>>>>>>>>>>> the >> > > > > > > > > > >>>>>>>>>>>>>>>>> release. >> > > > > > > > > > >>>>>>>>>>>>>>>>>> Any takers? >> > > > > > > > > > >>>>>>>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>>>>>> On Wed, Mar 2, 2016 at 11:07 PM, >> Parth >> > > > > Chandra < >> > > > > > > > > > >>>>>>>>>>>> par...@apache.org >> > > > > > > > > > >>>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>>>>> wrote: >> > > > > > > > > > >>>>>>>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> I've summarized the list of JIRs >> below. >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> The first set of pull requests is >> under >> > > > > review >> > > > > > > > > > >>>>> (or >> > > > > > > > > > >>>>>>>> have >> > > > > > > > > > >>>>>>>>>> some >> > > > > > > > > > >>>>>>>>>>>>>>>> reviewer >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> assigned). >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> The second set contains pull >> requests >> > > that >> > > > > need >> > > > > > > > > > >>>>>>>> review. >> > > > > > > > > > >>>>>>>>> We >> > > > > > > > > > >>>>>>>>>>>> need >> > > > > > > > > > >>>>>>>>>>>>>>>>>> committers >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> to review these. Please volunteer or >> > > these >> > > > > will >> > > > > > > > > > >>>>>> not >> > > > > > > > > > >>>>>>> be >> > > > > > > > > > >>>>>>>>>> able >> > > > > > > > > > >>>>>>>>>>> to >> > > > > > > > > > >>>>>>>>>>>>>> make >> > > > > > > > > > >>>>>>>>>>>>>>>> it >> > > > > > > > > > >>>>>>>>>>>>>>>>>> into >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> the release. >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> The third set is Jira's that do not >> > have >> > > a >> > > > > > patch >> > > > > > > > > > >>>>>>>> and/or >> > > > > > > > > > >>>>>>>>>>> should >> > > > > > > > > > >>>>>>>>>>>>> not >> > > > > > > > > > >>>>>>>>>>>>>>>> be >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> included because they require deeper >> > > > > scrutiny. >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> I'm hoping we can finalize the list >> of >> > > PRs >> > > > > that >> > > > > > > > > > >>>>>> can >> > > > > > > > > > >>>>>>> be >> > > > > > > > > > >>>>>>>>>>>> reviewed >> > > > > > > > > > >>>>>>>>>>>>> by >> > > > > > > > > > >>>>>>>>>>>>>>>>> Friday >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> morning and possibly *finalize the >> list >> > > of >> > > > > > > > > > >>>>> issues >> > > > > > > > > > >>>>>> to >> > > > > > > > > > >>>>>>>> be >> > > > > > > > > > >>>>>>>>>>>> included >> > > > > > > > > > >>>>>>>>>>>>>> by >> > > > > > > > > > >>>>>>>>>>>>>>>>>> Friday >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> end of day* so please take some >> time to >> > > > > review >> > > > > > > > > > >>>>> the >> > > > > > > > > > >>>>>>>> PRs. >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> Also note that the QA team has >> offered >> > to >> > > > do >> > > > > > > > > > >>>>>> sanity >> > > > > > > > > > >>>>>>>>>> testing >> > > > > > > > > > >>>>>>>>>>>> once >> > > > > > > > > > >>>>>>>>>>>>>> we >> > > > > > > > > > >>>>>>>>>>>>>>>>>> decide >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> on the final commit to be included, >> > > before >> > > > > the >> > > > > > > > > > >>>>>>> release >> > > > > > > > > > >>>>>>>>>>>> candidate >> > > > > > > > > > >>>>>>>>>>>>>> is >> > > > > > > > > > >>>>>>>>>>>>>>>>>> rolled >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> out, which helps with the release >> > > candidate >> > > > > > > > > > >>>>> moving >> > > > > > > > > > >>>>>>>>> forward >> > > > > > > > > > >>>>>>>>>>>>>> smoothly. >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> Here's the list - >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> *Committed for 1.6 -* >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> DRILL-4281/pr 400 (Drill should >> support >> > > > > inbound >> > > > > > > > > > >>>>>>>>>>> impersonation) >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> DRILL-4372/pr 377(?) (Drill >> Operators >> > and >> > > > > > > > > > >>>>>> Functions >> > > > > > > > > > >>>>>>>>> should >> > > > > > > > > > >>>>>>>>>>>>>> correctly >> > > > > > > > > > >>>>>>>>>>>>>>>>>> expose >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> their types within Calcite.) - >> Waiting >> > > for >> > > > > Aman >> > > > > > > > > > >>>>> to >> > > > > > > > > > >>>>>>>>> review. >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> DRILL-4313/pr 396 (Improved client >> > > > > > > > > > >>>>> randomization. >> > > > > > > > > > >>>>>>>>> Update >> > > > > > > > > > >>>>>>>>>>> JIRA >> > > > > > > > > > >>>>>>>>>>>>>> with >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> warnings about using the feature ) >> > > Sudheesh >> > > > > to >> > > > > > > > > > >>>>>>> review. >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> DRILL-3488/pr 388 (Java 1.8 support) >> > > Hanifi >> > > > > to >> > > > > > > > > > >>>>>>> review >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> DRILL-4437 (and others)/pr 394 >> > (Operator >> > > > unit >> > > > > > > > > > >>>>> test >> > > > > > > > > > >>>>>>>>>>> framework). >> > > > > > > > > > >>>>>>>>>>>>>>>> Parth to >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> review >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> DRILL-4384 - Query profile is >> missing >> > > > > important >> > > > > > > > > > >>>>>>>>>> information >> > > > > > > > > > >>>>>>>>>>> on >> > > > > > > > > > >>>>>>>>>>>>>>>> WebUi - >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> Marked as resolved. Patch not >> applied? >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> *Need review -* >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> DRILL-4465/pr 401 (Simplify Calcite >> > > > parsing & >> > > > > > > > > > >>>>>>> planning >> > > > > > > > > > >>>>>>>>>>>>>> integration) >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> DRILL-4375/pr 402 (Fix the maven >> > release >> > > > > > > > > > >>>>> profile) >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> DRILL-4452/pr 395 (Update Avatica >> > Driver >> > > to >> > > > > > > > > > >>>>> latest >> > > > > > > > > > >>>>>>>>>> Calcite) >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> DRILL-4332/pr 389 (Make vector >> > comparison >> > > > > order >> > > > > > > > > > >>>>>>> stable >> > > > > > > > > > >>>>>>>>> in >> > > > > > > > > > >>>>>>>>>>> test >> > > > > > > > > > >>>>>>>>>>>>>>>>> framework) >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> DRILL-4449/pr 389 (Wrong results >> when >> > > > > metadata >> > > > > > > > > > >>>>>> cache >> > > > > > > > > > >>>>>>>> is >> > > > > > > > > > >>>>>>>>>>>> used..) >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> DRILL-4416/pr 385 (quote path >> > separator) >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> DRILL-4411/pr 381 (hash join >> > over-memory >> > > > > > > > > > >>>>>> condition) >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> DRILL-4410/pr 380 (listvector should >> > > > > > initiatlize >> > > > > > > > > > >>>>>>>>> bits...) >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> DRILL-4387/pr 379 (GroupScan should >> not >> > > use >> > > > > > star >> > > > > > > > > > >>>>>>>> column) >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> DRILL-4383/pr 375 (Allow custom >> configs >> > > for >> > > > > S3, >> > > > > > > > > > >>>>>>>>> Kerberos, >> > > > > > > > > > >>>>>>>>>>> etc) >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> DRILL-4184/pr 372 (support variable >> > > length >> > > > > > > > > > >>>>> decimal >> > > > > > > > > > >>>>>>>>> fields >> > > > > > > > > > >>>>>>>>>> in >> > > > > > > > > > >>>>>>>>>>>>>>>> parquet) >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> DRILL-4069/pr 352 Enable RPC thread >> > > offload >> > > > > by >> > > > > > > > > > >>>>>>> default >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> DRILL-4120 - dir0 does not work when >> > the >> > > > > > > > > > >>>>> directory >> > > > > > > > > > >>>>>>>>>> structure >> > > > > > > > > > >>>>>>>>>>>>>>>> contains >> > > > > > > > > > >>>>>>>>>>>>>>>>>> Avro >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> files - Partial patch available. >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> *Not included (yet) - * >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> DRILL-3149 - No patch available >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> DRILL-4441 - IN operator does not >> work >> > > with >> > > > > > Avro >> > > > > > > > > > >>>>>>>> reader >> > > > > > > > > > >>>>>>>>> - >> > > > > > > > > > >>>>>>>>>> No >> > > > > > > > > > >>>>>>>>>>>>> patch >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> available >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> DRILL-3745/pr 399 - Hive char >> support - >> > > New >> > > > > > > > > > >>>>>> feature >> > > > > > > > > > >>>>>>> - >> > > > > > > > > > >>>>>>>>>> Needs >> > > > > > > > > > >>>>>>>>>>>> QA - >> > > > > > > > > > >>>>>>>>>>>>>> Not >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> included in 1.6 >> > > > > > > > > > >>>>>>>>>>>>>>>>>>> DRILL-3623 - Limit 0 should avoid >> > > execution >> > > > > > when >> > > > > > > > > > >>>>>>>>> querying >> > > > > > > > > > >>>>>>>> >> > ... > > [Message clipped]
