Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r56439803
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlOperatorNotInfer.java
---
@@ -0,0 +1,76 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * <p/>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p/>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.planner.sql;
+
+import com.google.common.base.Preconditions;
+import org.apache.calcite.rel.type.RelDataType;
+import org.apache.calcite.rel.type.RelDataTypeFactory;
+import org.apache.calcite.sql.SqlCall;
+import org.apache.calcite.sql.SqlOperatorBinding;
+import org.apache.calcite.sql.type.SqlTypeName;
+import org.apache.calcite.sql.validate.SqlValidator;
+import org.apache.calcite.sql.validate.SqlValidatorScope;
+import org.apache.drill.common.types.TypeProtos;
+import org.apache.drill.exec.expr.fn.DrillFuncHolder;
+
+import java.util.ArrayList;
+
+public class DrillSqlOperatorNotInfer extends DrillSqlOperator {
+ private static final TypeProtos.MajorType NONE =
TypeProtos.MajorType.getDefaultInstance();
+ private final TypeProtos.MajorType returnType;
+
+ public DrillSqlOperatorNotInfer(String name, int argCount,
TypeProtos.MajorType returnType, boolean isDeterminisitic) {
+ super(name,
+ new ArrayList< DrillFuncHolder>(),
+ argCount,
+ argCount,
+ isDeterminisitic,
+ DynamicReturnType.INSTANCE);
+ this.returnType = Preconditions.checkNotNull(returnType);
+ }
+
+ protected RelDataType getReturnDataType(final RelDataTypeFactory
factory) {
+ if (TypeProtos.MinorType.BIT.equals(returnType.getMinorType())) {
+ return factory.createSqlType(SqlTypeName.BOOLEAN);
+ }
+ return
factory.createTypeWithNullability(factory.createSqlType(SqlTypeName.ANY), true);
+ }
+
+ private RelDataType getNullableReturnDataType(final RelDataTypeFactory
factory) {
+ return factory.createTypeWithNullability(getReturnDataType(factory),
true);
+ }
+
+ @Override
+ public RelDataType deriveType(SqlValidator validator, SqlValidatorScope
scope, SqlCall call) {
+ if (NONE.equals(returnType)) {
+ return validator.getTypeFactory().createSqlType(SqlTypeName.ANY);
--- End diff --
Similar to the one in DrillSqlAggOperatorNotInfer.java. Please see [1]
[1]
https://github.com/apache/drill/blob/d7eebec41a1636055be1b2c79b693d76c52d8932/exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlOperator.java#L71
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
