Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r56397383
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillOperatorTable.java
---
@@ -43,24 +46,49 @@
public class DrillOperatorTable extends SqlStdOperatorTable {
// private static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(DrillOperatorTable.class);
private static final SqlOperatorTable inner =
SqlStdOperatorTable.instance();
- private List<SqlOperator> operators = Lists.newArrayList();
+ private final List<SqlOperator> operatorsCalcite = Lists.newArrayList();
+ private final List<SqlOperator> operatorsDefault = Lists.newArrayList();
+ private final List<SqlOperator> operatorsInferernce =
Lists.newArrayList();
private final Map<SqlOperator, SqlOperator> calciteToWrapper =
Maps.newIdentityHashMap();
- private ArrayListMultimap<String, SqlOperator> opMap =
ArrayListMultimap.create();
+
+ private final ArrayListMultimap<String, SqlOperator> opMapDefault =
ArrayListMultimap.create();
+ private final ArrayListMultimap<String, SqlOperator> opMapInferernce =
ArrayListMultimap.create();
+
+ private final SystemOptionManager systemOptionManager;
public DrillOperatorTable(FunctionImplementationRegistry registry) {
+ this(registry, null);
--- End diff --
Why do we have this constructor, with systemOptionManager = null? Can we
remove it ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
