Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/454#discussion_r57955905
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java
---
@@ -110,11 +111,12 @@
private LinkedList<BatchGroup> batchGroups = Lists.newLinkedList();
private LinkedList<BatchGroup> spilledBatchGroups =
Lists.newLinkedList();
private SelectionVector4 sv4;
- private FileSystem fs;
+ private static FileSystem fs;
--- End diff --
Won't making this static and closing it cause other queries with an
external sort to fail? You should be able to put this in the close() method of
this class so that it only impacts the local instance. It looks like the
directory created includes the operator ID, so there shouldn't be a need to
keep around the spill directory until the foreman close method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
