Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/454#discussion_r58108889
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java
---
@@ -110,11 +111,12 @@
private LinkedList<BatchGroup> batchGroups = Lists.newLinkedList();
private LinkedList<BatchGroup> spilledBatchGroups =
Lists.newLinkedList();
private SelectionVector4 sv4;
- private FileSystem fs;
+ private static FileSystem fs;
--- End diff --
looks like the github markdown killed part of you message, it did get
through to the email they sent out, copied modified versions of the paths here:
root spill dir / query_id / major_frag_id / minor_frag_id / operator_id/
Instead we should make it:
root spill dir / query_id__major_frag_id__minor_frag_id__operator_id /
I don't think we need the double underscores in the path, I just did that
to separate the components of the directory name.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
