Github user JohnOmernik commented on a diff in the pull request:
https://github.com/apache/drill/pull/474#discussion_r59064857
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java ---
@@ -207,6 +209,28 @@ private void javaPropertiesToSystemOptions() {
}
/**
+ * Disallow registering drillbit when:
+ * 1. version is unknown;
+ * 2. drillbit with different version has been already registered.
--- End diff --
Agreed. In addition to potential soft enforcement, I think we should
consider the differences of a version defined in a pom.xml, the version of the
running drillbit, and the version of a drill cluster. By using a setting in
drill-override to specify what the drill cluster version is, we don't get
accident "first bit to register is the wrong version" situations. Are there
situations where we might want to allow a specific Drill version + all minor
versions at that level, or Drill version + 1 Major version for rolling upgrades?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
