Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/474#discussion_r59077998
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java ---
@@ -207,6 +209,28 @@ private void javaPropertiesToSystemOptions() {
}
/**
+ * Disallow registering drillbit when:
+ * 1. version is unknown;
+ * 2. drillbit with different version has been already registered.
+ */
+ private void checkVersion(DrillbitEndpoint endpoint) throws
DrillbitStartupException {
+ String currentVersion = endpoint.getVersion();
+ if (DrillVersionInfo.UNKNOWN_VERSION.equals(currentVersion)) {
+ throw new DrillbitStartupException("Drillbit version is unknown.");
+ }
+
+ for (DrillbitEndpoint registeredEnpoint :
coord.getAvailableEndpoints()) {
+ if (!currentVersion.equals(registeredEnpoint.getVersion())) {
--- End diff --
Agree. Probably it's better to compare each module major versions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
