Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/454#discussion_r60572146
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java
---
@@ -550,7 +565,15 @@ public BatchGroup mergeAndSpill(LinkedList<BatchGroup>
batchGroups) throws Schem
c1.buildSchema(BatchSchema.SelectionVectorMode.NONE);
c1.setRecordCount(count);
- String outputFile = Joiner.on("/").join(dirs.next(), fileName,
spillCount++);
+ String spillDir = dirs.next();
+ Path currSpillPath = new Path(Joiner.on("/").join(spillDir, fileName));
+ currSpillDirs.add(currSpillPath);
+ String outputFile = Joiner.on("/").join(currSpillPath, spillCount++);
+ try {
+ fs.deleteOnExit(currSpillPath);
+ } catch (IOException e) {
+ throw new RuntimeException(e);
--- End diff --
Agree. An exception throw was replaced with:
```
// since this is meant to be used in a batches's spilling, we don't
propagate the exception
final String message = "Unable to mark spill directory \"" + currSpillPath
+ "\" to delete on exit";
System.err.println(message + '.');
logger.warn(message, e);
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
