Github user laurentgo commented on a diff in the pull request:

    https://github.com/apache/drill/pull/507#discussion_r64602614
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java 
---
    @@ -159,6 +163,14 @@ public void start() throws Exception {
           
servletContextHandler.setSessionHandler(createSessionHandler(servletContextHandler.getSecurityHandler()));
         }
     
    +    if (config.getBoolean(ExecConstants.HTTP_ENABLE_CORS)) {
    +      FilterHolder cors = 
servletContextHandler.addFilter(CrossOriginFilter.class, "/*", 
EnumSet.of(DispatcherType.REQUEST));
    +      cors.setInitParameter(CrossOriginFilter.ALLOWED_ORIGINS_PARAM, "*");
    +      
cors.setInitParameter(CrossOriginFilter.ACCESS_CONTROL_ALLOW_ORIGIN_HEADER, 
"*");
    --- End diff --
    
    if it doesn't end with _PARAM, it probably means it's not a param but a 
constant used for something else (likely to set a HTTP header in the response). 
It's probably harmless, but better be removed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to