Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/507#discussion_r64603060
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java
---
@@ -159,6 +163,14 @@ public void start() throws Exception {
servletContextHandler.setSessionHandler(createSessionHandler(servletContextHandler.getSecurityHandler()));
}
+ if (config.getBoolean(ExecConstants.HTTP_ENABLE_CORS)) {
+ FilterHolder cors =
servletContextHandler.addFilter(CrossOriginFilter.class, "/*",
EnumSet.of(DispatcherType.REQUEST));
+ cors.setInitParameter(CrossOriginFilter.ALLOWED_ORIGINS_PARAM, "*");
--- End diff --
Not so much experience regarding CORS, but should we expect admins to need
to restrict this to a specific set of origins? I believe so, but I hope people
more experienced regarding web security to comment on that. My take is that we
should probably make it configurable too. Default to * is probably although not
as restrictive as the same-origin policy used when filter is disabled.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
