Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/521#discussion_r67018273
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/ClassGenerator.java ---
@@ -86,14 +88,16 @@ public static MappingSet getDefaultMapping() {
}
@SuppressWarnings("unchecked")
- ClassGenerator(CodeGenerator<T> codeGenerator, MappingSet mappingSet,
SignatureHolder signature, EvaluationVisitor eval, JDefinedClass clazz,
JCodeModel model) throws JClassAlreadyExistsException {
+ ClassGenerator(CodeGenerator<T> codeGenerator, MappingSet mappingSet,
SignatureHolder signature, EvaluationVisitor eval, JDefinedClass clazz,
JCodeModel model, OptionManager optionManager) throws
JClassAlreadyExistsException {
this.codeGenerator = codeGenerator;
this.clazz = clazz;
this.mappings = mappingSet;
this.sig = signature;
this.evaluationVisitor = eval;
this.model = model;
- blocks = (LinkedList<JBlock>[]) new LinkedList[sig.size()];
+ this.optionManager = optionManager;
--- End diff --
Looks like the `optionManager` being passed down is system level. Make this
explicit by renaming `optionManager` to `systemOptions`.
Users also need to be aware.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
