Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/521#discussion_r67442526
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/ClassGenerator.java ---
@@ -215,22 +219,47 @@ public JVar
declareVectorValueSetupAndMember(DirectExpression batchName, TypedFi
return vv;
}
+ public enum RotateMode {
--- End diff --
The name 'RotateMode' seems a misnomer since there is no actual re-use or
rotation of the JBlocks, right ? It is confusing. Should we call this
BlockCreationMode ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
