Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/518#discussion_r67426381
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONRecordReader.java
---
@@ -189,39 +191,33 @@ private long currentRecordNumberInFile() {
public int next() {
writer.allocate();
writer.reset();
-
recordCount = 0;
ReadState write = null;
-// Stopwatch p = new Stopwatch().start();
- try{
- outside: while(recordCount < DEFAULT_ROWS_PER_BATCH) {
- writer.setPosition(recordCount);
- write = jsonReader.write(writer);
-
- if(write == ReadState.WRITE_SUCCEED) {
-// logger.debug("Wrote record.");
- recordCount++;
- }else{
-// logger.debug("Exiting.");
- break outside;
- }
-
+ outside: while(recordCount < DEFAULT_ROWS_PER_BATCH){
+ try
+ {
+ writer.setPosition(recordCount);
--- End diff --
seems this is still doing indent of 4. We use 2 spaces (see
https://drill.apache.org/docs/apache-drill-contribution-guidelines/ scroll
down to Step 2). Did it pass the mvn command line build without checkstyle
violations ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
