Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/518#discussion_r70863798
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java
---
@@ -110,21 +118,29 @@ public void ensureAtLeastOneField(ComplexWriter
writer) {
emptyStatus.set(i, true);
}
if (i == 0 && !allTextMode) {
- // when allTextMode is false, there is not much benefit to
producing all the empty
- // fields; just produce 1 field. The reason is that the type of
the fields is
- // unknown, so if we produce multiple Integer fields by default, a
subsequent batch
- // that contains non-integer fields will error out in any case.
Whereas, with
- // allTextMode true, we are sure that all fields are going to be
treated as varchar,
- // so it makes sense to produce all the fields, and in fact is
necessary in order to
+ // when allTextMode is false, there is not much benefit to
producing all
--- End diff --
Seems the line width changed here(line 121-132). Please reorganize the
text. If possible keep the original text unchanged. The same in line 140-143
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
