Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/519#discussion_r67567343
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java
 ---
    @@ -269,13 +283,54 @@ protected void doOnMatch(RelOptRuleCall call, Filter 
filterRel, Project projectR
             int recordCount = 0;
             int qualifiedCount = 0;
     
    -        // Inner loop: within each batch iterate over the 
PartitionLocations
    -        for(PartitionLocation part: partitions){
    -          if(!output.getAccessor().isNull(recordCount) && 
output.getAccessor().get(recordCount) == 1){
    -            newPartitions.add(part);
    -            qualifiedCount++;
    +        if (checkForSingle &&
    +            partitions.get(0).isCompositePartition() /* apply single 
partition check only for composite partitions */) {
    +          // Inner loop: within each batch iterate over the 
PartitionLocations
    +          for (PartitionLocation part : partitions) {
    --- End diff --
    
    Do you think it's possible to refactor this part of code such that only 
file system prune scan will have this logic?  This simplePartition optimization 
only applies to file system prune. Also, doOnMatch() method is getting bigger. 
Something like:  descriptor has supportsSinglePartOptimization(), and prune 
scan rule has doSinglePartOpt(), which is by default a no-op, and has 
implementation for file system prune rule.
     


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to