Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/519#discussion_r67567703
  
    --- Diff: 
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/planner/sql/HivePartitionDescriptor.java
 ---
    @@ -151,7 +152,7 @@ protected void createPartitionSublists() {
       }
     
       @Override
    -  public TableScan createTableScan(List<PartitionLocation> newPartitions) 
throws Exception {
    +  public TableScan createTableScan(List<PartitionLocation> newPartitions, 
String cacheFileRoot) throws Exception {
    --- End diff --
    
    From the comment, cacheFileRoot could be null. But is it possible to not 
adding this parameter to HivePartitionDescriptor? After all, cacheFileRoot will 
not be applied to hive partition. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to