Github user jaltekruse commented on the issue:
https://github.com/apache/drill/pull/518
I don't think we should merge this without a mechanism to return a warning
to the user to tell them at least that some data was ignored, and ideally some
indication of how much data was discarded. While I do understand this is not
the default behavior, I think there is still too high of a risk that an admin
could set this at a global level and users would be unaware of some of their
data being discarded.
I am willing to discuss the benefits of merging this before such a system
exists, but until this issue has been thoroughly evaluated I am -1 on the
change.
One improvement you could make to the current implementation is moving the
option to the format plugin instead of the system/session list. This enables
users to include setting the option in there query with the "table with
options" syntax that was added last fall. We already have a JIRA open for
moving the all_text_mode and read_numbers_as_double options to this location,
because it doesn't really make sense to change query results based on session
state. Unfortunately this change does not completely remove my initial concern,
because not all users can modify or see the storage plugins in the case when
web UI security is enabled. Non-admin users in these cases could be surprised
by this behavior.
For examples of how this is done, you can look at the text plugin config,
you would just need to add these options as properties to the json config which
is currently mostly empty.
https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONFormatPlugin.java#L93
https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/TextFormatPlugin.java#L135
Select with options: https://issues.apache.org/jira/browse/DRILL-4047
Jira for moving the existing options:
https://issues.apache.org/jira/browse/DRILL-4206
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
