Github user daveoshinsky commented on the issue:
https://github.com/apache/drill/pull/517
Got it. Â I added a commit, but cleaned up your changes to centralize the
duplicated code in a function. Â As discussed, this method might increase the
chances of an overflow, but it avoids changing the cast. Â Also, if there are
any other places in the code that pass an invalid (zero) precision to the cast,
those will now exhibit the same bug, as the cast is vulnerable (without my
earlier fix) to such a bad argument.
On Monday, August 8, 2016 3:58 PM, Jinfeng Ni
<[email protected]> wrote:
This is the prototype patch I tried [1]. I replied with the link in our
prior direct communication. [1]
https://github.com/jinfengni/incubator-drill/commits/review/DRILL-4704â
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
