Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/574#discussion_r77707167
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java
---
@@ -218,4 +302,141 @@ private void
registerOperatorsWithoutInference(DrillOperatorTable operatorTable)
}
}
}
+
+ /**
+ * Function registry holder. Stores function implementations by jar
name, function name.
+ */
+ private class GenericRegistryHolder<T, U> {
--- End diff --
How is this class tested? Being a private, inner class, it is impossible to
unit test. Not convinced adequate testing can be done by testing Drill as a
whole via SQL statements. This may be a project philosophy issue if we don't
require "unit" tests in the traditional meaning: tests of specific modules
outside the context of the entire system.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
