Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/574#discussion_r77739498
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillSimpleFuncHolder.java
---
@@ -40,10 +40,12 @@
static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(DrillSimpleFuncHolder.class);
private final String drillFuncClass;
+ private final ClassLoader classLoader;
--- End diff --
Please insert a comment explaining the purpose of the class loader. As we
know, the use is a bit of a trick when loading dynamic jars, so future readers
will want some hints for how things work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
