Github user chunhui-shi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/605#discussion_r82488363
  
    --- Diff: distribution/src/resources/drill-config.sh ---
    @@ -392,5 +392,7 @@ export DRILL_HOME
     export DRILL_CONF_DIR
     export DRILL_LOG_DIR
     export CP
    -export JAVA_HOME
    --- End diff --
    
    In drillbit.sh, we refer to JAVA_HOME with this '$JAVA_HOME/bin/jstack', is 
that piece of code still working after we do not export JAVA_HOME here?
    Maybe it is better we limit the impact of not exporting JAVA_HOME to MAC 
and keep the same behavior on Linux(and other OSes)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to