Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/605#discussion_r82496282
--- Diff: distribution/src/resources/drill-config.sh ---
@@ -392,5 +392,7 @@ export DRILL_HOME
export DRILL_CONF_DIR
export DRILL_LOG_DIR
export CP
-export JAVA_HOME
+# DRILL-4870: Don't export JAVA_HOME. Java can find it just fine from the
java
+# command. If we attempt to work out out, we do so incorrectly for the Mac.
--- End diff --
+1. Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
