Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/600#discussion_r83852721
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java
---
@@ -899,18 +883,21 @@ public void testLastPageOneNull() throws Exception {
"cp.`parquet/last_page_one_null.parquet`");
}
- private void compareParquetInt96Converters(String newInt96ConverterQuery,
- String oldInt96ConverterAndConvertFromFunctionQuery) throws
Exception {
- testBuilder()
- .ordered()
- .sqlQuery(newInt96ConverterQuery)
- .optionSettingQueriesForTestQuery(
- "alter session set `%s` = true",
ExecConstants.PARQUET_READER_INT96_AS_TIMESTAMP)
- .sqlBaselineQuery(oldInt96ConverterAndConvertFromFunctionQuery)
- .optionSettingQueriesForBaseline(
- "alter session set `%s` = false",
ExecConstants.PARQUET_READER_INT96_AS_TIMESTAMP)
- .build()
- .run();
+ private void compareParquetInt96Converters(String selection, String
table) throws Exception {
+ try {
--- End diff --
I refactored my helped method with more clear code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
