Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/600#discussion_r85124582 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java --- @@ -739,30 +739,54 @@ public void runTestAndValidate(String selection, String validationSelection, Str } /* - Test the reading of an int96 field. Impala encodes timestamps as int96 fields + Impala encodes timestamp values as int96 fields. Test the reading of an int96 field with two converters: + the first one converts parquet INT96 into drill VARBINARY and the second one (works while + store.parquet.reader.int96_as_timestamp option is enabled) converts parquet INT96 into drill TIMESTAMP. */ @Test public void testImpalaParquetInt96() throws Exception { compareParquetReadersColumnar("field_impala_ts", "cp.`parquet/int96_impala_1.parquet`"); + try { + test("alter session set %s = true", ExecConstants.PARQUET_READER_INT96_AS_TIMESTAMP); + compareParquetReadersColumnar("field_impala_ts", "cp.`parquet/int96_impala_1.parquet`"); --- End diff -- The above comment was addressed to the [testImpalaParquetBinaryAsTimeStamp_DictChange](https://github.com/apache/drill/pull/600/commits/81c48c9cd5cdc3905ea78c6cad07a9d818d5026f#diff-aab74a5027942e775c846cebc06c32a4R771) method Test was updated: An old incorrect file int96_dict_change.parquet was replaced with the new two ones with int96 timestamp field and different encoded pages (dictionary and non-dictionary). Csv baseline file also was added.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---