Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/602#discussion_r85434357
--- Diff: contrib/native/client/cmakeModules/FindZookeeper.cmake ---
@@ -30,8 +30,10 @@
if (MSVC)
if(${CMAKE_BUILD_TYPE} MATCHES "Debug")
set(ZK_BuildOutputDir "Debug")
+ set(ZK_LibName "zookeeper_d")
else()
set(ZK_BuildOutputDir "Release")
+ set(ZK_LibName "zookeeper_d")
--- End diff --
Spent the better part of a day on this now. The Zookeeper project has
defined only the 32 bit configurations these have the lib name set to
'zookeeper_d.lib' for debug and 'zookeeper.lib' for release.
When creating a 64 bit configuration, depending on the path you choose, you
can end up with either zookeeper_d.lib or zookeeper.lib as the import library
name in both the release and debug build configurations.
For correctness, I think we should use 'zookeeper' and not zookeeper_d for
the release build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
