Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/660#discussion_r91642556
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java
 ---
    @@ -711,18 +711,20 @@ private MSorter createNewMSorter(FragmentContext 
context, List<Ordering> orderin
         g.rotateBlock();
         g.getEvalBlock()._return(JExpr.lit(0));
     
    +    cg.plainOldJavaCapable(true); // This class can generate plain-old 
Java.
    + // Uncomment out this line to debug the generated code.
    +//  cg.preferPlainOldJavaJava(true);
         return context.getImplementationClass(cg);
    -
    -
       }
     
       public SingleBatchSorter createNewSorter(FragmentContext context, 
VectorAccessible batch)
               throws ClassTransformationException, IOException, 
SchemaChangeException{
         CodeGenerator<SingleBatchSorter> cg = 
CodeGenerator.get(SingleBatchSorter.TEMPLATE_DEFINITION, 
context.getFunctionRegistry(), context.getOptions());
    -    ClassGenerator<SingleBatchSorter> g = cg.getRoot();
    -
    -    generateComparisons(g, batch);
    +    cg.plainOldJavaCapable(true); // This class can generate plain-old 
Java.
     
    +    // Uncomment out this line to debug the generated code.
    +//    cg.preferPlainOldJavaJava(true);
    --- End diff --
    
    Fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to