Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/660#discussion_r91638703 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/DrillJavaFileObject.java --- @@ -67,6 +72,14 @@ public boolean isCompiled() { } } + public Map<String,byte[]> getResults( ) { + Map<String,byte[]> results = new HashMap<>( ); --- End diff -- There is a note in the Java 8 docs that say that the newFoo() pattern was needed in prior Java versions to avoid: `Map<String,Integer> foo = new HashMap<String,Integer>();` But, under Java 7 (the diamond syntax was introduced with type inference, so the current preferred idiom is: `Map<String,Integer> foo = new HashMap<>();` Drill code seems to have been written before the diamond syntax was available.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---