Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/594#discussion_r92452185
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java
---
@@ -510,10 +517,13 @@ private void writeDataAllText(MapWriter map,
FieldSelection selection,
case VALUE_NUMBER_FLOAT:
case VALUE_NUMBER_INT:
case VALUE_STRING:
+ removeNotNullColumn(fieldName);
--- End diff --
I feel uncomfortable since the fix added 'removeNotNullColumn(fieldName)'
on the code path that is supposed to be hotspot. Could the reader just clean
'path' if it knows it is recovering from some errors?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
