Github user Serhii-Harnyk commented on a diff in the pull request:

    https://github.com/apache/drill/pull/594#discussion_r92478836
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java
 ---
    @@ -510,10 +517,13 @@ private void writeDataAllText(MapWriter map, 
FieldSelection selection,
           case VALUE_NUMBER_FLOAT:
           case VALUE_NUMBER_INT:
           case VALUE_STRING:
    +        removeNotNullColumn(fieldName);
    --- End diff --
    
    To clean 'path' if it knows it is recovering from some errors, was added 
this line: 
https://github.com/Serhii-Harnyk/drill/blob/9ce6d56b46bcd540697c85cd2f280831dd50b277/exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java#L243.
 Call of the method removeNotNullColumn() is a try to optimize the final size 
of the map fieldPathWriter, by removing fields, which were added to the map and 
initializing at current iteration.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to