Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/685
-1 to changes after refactoring.
using withSessionContext() is optional, so somebody can create a session
without it's unique id (for example, for CTTAS it's not acceptable). I suggest
we revert to previous design where session id is created in constructor, it's
safe and transparent. And I am not sure that we need the whole new class
`UserSessionContext` to hold session id.
@nagarajanchinnasamy, next time you refactor your changes after PR was
reviewed, I guess it's better to add these changes in separate commit, so they
can be reviewed easier. You'll be asked to squash your commits when review is
done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
