Hi Laurent, Thanks for the update.
I'm putting the patches in a merge branch, and will merge to master once I complete the regression run. On Wed, Mar 1, 2017 at 6:18 PM, Laurent Goujon <[email protected]> wrote: > The C++ patches have been built under windows/Linux/macos, and sanity > checks have been done for all of them. For the escape character fix and the > cancel fix, those have been tested in production like environment for weeks. > > Laurent > > On Mar 1, 2017 13:10, "Jinfeng Ni" <[email protected]> wrote: > > Hi Laurent, > > Thanks for the update. For the C++ client commits (DRILL-5301, > DRILL-5221), did you guys run some sanity check to see if there is any > regression? I know Parth used to build/test with the new C++ change. > Since he is not available this time, just wanna to check if you have > done similar things. > > Thanks, > > Jinfeng > > > > On Wed, Mar 1, 2017 at 10:31 AM, Laurent Goujon <[email protected]> wrote: >> The following jiras have all been reviewed and are ready to commit: >> * DRILL-4994: Add back JDBC prepared statement for older servers >> * DRILL-4730: Update JDBC DatabaseMetaData implementation to use new >> Metadata APIs >> * DRILL-5301: Server metadata API >> * DRILL-5167: Send escape character for metadata queries >> * DRILL-5221: Send cancel message as soon as possible in C++ connector >> >> For DRILL-3510 (Add ANSI_QUOTES option so that Drill's SQL Parser will >> recognize ANSI_SQL identifiers), it's my understanding that Vitalii would >> wait for DRILL-5301 changes to be merged, and refactor his patch on top of >> it, and I guess it will be post 1.10 >> >> Laurent >> >> >> >> On Mon, Feb 27, 2017 at 3:07 PM, Jinfeng Ni <[email protected]> wrote: >> >>> The proposed cutoff date is this Wednesday, March 1st. >>> >>> I normally will just @someone in the PRs, so that someone would get >>> notice of PR, and hopefully get it reviewed. >>> >>> >>> >>> On Mon, Feb 27, 2017 at 2:42 PM, Laurent Goujon <[email protected]> >>> wrote: >>> > Thanks for the heads up: I'll try to ping directly some committers to >>> > review my changes. >>> > >>> > For information, what's the official cutoff date? >>> > >>> > Laurent >>> > >>> > PS: it's too bad that people with expertise don't have time to review > my >>> > patches, since some of them have been open for weeks or even months > (e.g. >>> > DRILL-4730 was cut out of Drill 1.9). If some people have suggestions > on >>> > what I should have done differently, I would greatly appreciate the >>> > feedback. >>> > >>> > On Mon, Feb 27, 2017 at 2:18 PM, Jinfeng Ni <[email protected]> wrote: >>> > >>> >> Here are the current status for the pending PRs for 1.10. >>> >> >>> >> JIRAs have been merged into Apache master branches: >>> >> >>> >> DRILL-4280 >>> >> DRILL-5275 >>> >> DRILL-5260 >>> >> DRILL-5273 >>> >> DRILL-5257 >>> >> DRILL-5255 >>> >> DRILL-5274 >>> >> >>> >> JIRAs that are in "ready-to-commit" status: >>> >> DRILL-5258 >>> >> DRILL-5034 >>> >> DRILL-4963 >>> >> DRILL-5252 >>> >> >>> >> JIRAs that have review comments to address: >>> >> DRILL-5266 >>> >> DRILL-5114 >>> >> DRILL-5284 >>> >> >>> >> @Laurent, for the JDBC PRs you want to merge, is it possible that you >>> >> may get someone to review the PRs? Since both Sudheesh and Parth >>> >> (people have expertise) are on travel currently, it probably is not >>> >> likely that one of them can review your PRs before the cutoff for >>> >> 1.10. >>> >> >>> >> Thanks, >>> >> Jinfeng >>> >> >>> >> >>> >> >>> >> >>> >> On Mon, Feb 27, 2017 at 9:48 AM, Laurent Goujon <[email protected]> >>> >> wrote: >>> >> > Hi Jinfeng, >>> >> > >>> >> > Thanks for volunteering: >>> >> > >>> >> > Please consider the following JIRAs (PRs already open): >>> >> > * DRILL-4994: Add back JDBC prepared statement for older servers >>> >> > * DRILL-4730: Update JDBC DatabaseMetaData implementation to use new >>> >> > Metadata APIs >>> >> > * DRILL-5301: Server metadata API >>> >> > * DRILL-5167: Send escape character for metadata queries >>> >> > * DRILL-5221: Send cancel message as soon as possible in C++ > connector >>> >> > * DRILL-3510: Add ANSI_QUOTES option so that Drill's SQL Parser will >>> >> > recognize ANSI_SQL identifiers >>> >> > >>> >> > >>> >> > >>> >> > On Fri, Feb 24, 2017 at 5:22 AM, Arina Yelchiyeva < >>> >> > [email protected]> wrote: >>> >> > >>> >> >> Hi Jinfeng, >>> >> >> >>> >> >> please also consider the following Jiras (PR are already open): >>> >> >> * DRILL-4963: Issues when overloading Drill native functions with >>> >> dynamic >>> >> >> UDFs >>> >> >> * DRILL-5255: Remove default temporary workspace check at drillbit >>> >> start up >>> >> >> * DRILL-5274: Exception thrown in Drillbit shutdown in UDF cleanup >>> code >>> >> >> >>> >> >> Kind regards >>> >> >> Arina >>> >> >> >>> >> >> On Thu, Feb 23, 2017 at 8:40 PM, Paul Rogers <[email protected]> >>> wrote: >>> >> >> >>> >> >> > Hi Jinfeng, >>> >> >> > >>> >> >> > Thanks for volunteering! >>> >> >> > >>> >> >> > The following are working their way though the system: >>> >> >> > >>> >> >> > PRs outstanding: >>> >> >> > >>> >> >> > * DRILL-5275: Sort spill is slow due to repeated allocations >>> >> >> > * DRILL-5260: Extend "Cluster Fixture" test framework >>> >> >> > * DRILL-5258: Access mock data definition from SQL >>> >> >> > * DRILL-5273: CompliantTextReader excessive memory use >>> >> >> > * DRILL-5266: Parquet returns low-density batches >>> >> >> > * DRILL-5257: Run-time control of query profiles >>> >> >> > >>> >> >> > The following community contribution has been approved and is >>> ready to >>> >> >> > commit: >>> >> >> > >>> >> >> > * DRILL-5252: Fix a condition that always returns true >>> >> >> > >>> >> >> > The following will be (re)issued today or tomorrow: >>> >> >> > >>> >> >> > * DRILL-5114: Rationalize use of Logback logging in unit tests >>> >> >> > * DRILL-5284: Roll-up of final fixes for managed sort >>> >> >> > >>> >> >> > Thanks, >>> >> >> > >>> >> >> > - Paul >>> >> >> > >>> >> >> > > On Feb 23, 2017, at 9:57 AM, Sudheesh Katkam <[email protected]> >>> >> wrote: >>> >> >> > > >>> >> >> > > I would like to include: >>> >> >> > > >>> >> >> > > + DRILL-4280: https://github.com/apache/drill/pull/578 (going >>> >> through >>> >> >> > the last round of comments) >>> >> >> > > >>> >> >> > > Thank you, >>> >> >> > > Sudheesh >>> >> >> > > >>> >> >> > >> On Feb 22, 2017, at 11:16 PM, Jinfeng Ni <[email protected]> >>> wrote: >>> >> >> > >> >>> >> >> > >> Hi Drillers, >>> >> >> > >> >>> >> >> > >> It has been almost 3 months since we release Drill 1.9. We > have >>> >> >> > >> resolved plenty of fixes and improvements (closed around 88 >>> JIRAs >>> >> >> > >> [1]). I propose that we start the 1.10 release process, and > set >>> >> >> > >> Wednesday 3/1 as the cutoff day for code checkin. After 3/1, > we >>> >> should >>> >> >> > >> start build a release candidate. >>> >> >> > >> >>> >> >> > >> Please reply in this email thread if you have something near >>> >> complete >>> >> >> > >> and you would like to include in 1.10 release. >>> >> >> > >> >>> >> >> > >> I volunteer as the release manager, unless someone else come >>> >> forward. >>> >> >> > >> >>> >> >> > >> Thanks, >>> >> >> > >> >>> >> >> > >> Jinfeng >>> >> >> > >> >>> >> >> > >> [1] https://issues.apache.org/jira/browse/DRILL/ >>> >> >> fixforversion/12338769 >>> >> >> > > >>> >> >> > >>> >> >> > >>> >> >> >>> >> >>>
