Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/796#discussion_r108048339
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/DrillFileSystem.java
 ---
    @@ -89,22 +89,36 @@ public DrillFileSystem(Configuration fsConf) throws 
IOException {
       }
     
       public DrillFileSystem(Configuration fsConf, OperatorStats 
operatorStats) throws IOException {
    -    this.underlyingFs = FileSystem.get(fsConf);
    +    this(fsConf, URI.create(fsConf.getRaw(FS_DEFAULT_NAME_KEY)), 
operatorStats);
    --- End diff --
    
    Not sure that `getRaw()` is what we want:
    
    > Get the value of the name property, without doing variable expansion.
    
    I suspect we want `getTrimmed()`.
    
    Also, can the value be null? If so, should we fall back to 
`FileSystem.DEFAULT_FS`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to