Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/807#discussion_r110238313
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java ---
@@ -203,7 +219,15 @@ private void createConfig(FixtureBuilder builder)
throws Exception {
if (builder.configResource != null) {
config = DrillConfig.create(builder.configResource);
} else if (builder.configProps != null) {
- config = DrillConfig.create(configProperties(builder.configProps));
+ // Create Config object out of all the String type configuration.
--- End diff --
Suggestion to keep things tidy. Keep all properties (simple and complex) in
the builder's `configProps` object. Then, in `configProperties`, do the mapping
as required to create the `DrillConfig`. If a value is a collection, use the
new code to set the value. Else, convert the value using `toString()`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
