Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/807#discussion_r110240217
  
    --- Diff: 
exec/java-exec/src/test/java/org/apache/drill/test/FixtureBuilder.java ---
    @@ -117,7 +122,27 @@ public FixtureBuilder configProperty(String key, 
Object value) {
         if (configProps == null) {
           configProps = defaultProps();
         }
    -    configProps.put(key, value.toString());
    +
    +    if(value instanceof Collection<?>) {
    --- End diff --
    
    Can we just leave the collection in the single `configProps` object, and do 
the mapping when creating the final config? That is, for the DrillConfig, make 
the collection test when building DrillConfig. See comment above.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to