Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/818#discussion_r113831429
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassTransformer.java
 ---
    @@ -264,7 +265,13 @@ public boolean equals(Object obj) {
             final ClassNames nextPrecompiled = nextSet.precompiled;
             final byte[] precompiledBytes = 
byteCodeLoader.getClassByteCodeFromPath(nextPrecompiled.clazz);
             final ClassNames nextGenerated = nextSet.generated;
    -        final ClassNode generatedNode = 
classesToMerge.get(nextGenerated.slash);
    +        Pair<byte[], ClassNode> classNodePair = 
classesToMerge.remove(nextGenerated.slash);
    +        final ClassNode generatedNode;
    +        if (classNodePair != null) {
    +          generatedNode = classNodePair.getValue();
    +        } else {
    +          generatedNode = null;
    --- End diff --
    
    What does it mean by "generatedNode = null"? Will it cause problem in 
subsequent call at line 288?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to