Github user vvysotskyi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/818#discussion_r114603169
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/expr/ClassGenerator.java ---
    @@ -66,7 +68,17 @@
       public static final GeneratorMapping DEFAULT_CONSTANT_MAP = 
GM("doSetup", "doSetup", null, null);
     
       static final org.slf4j.Logger logger = 
org.slf4j.LoggerFactory.getLogger(ClassGenerator.class);
    -  public static enum BlockType {SETUP, EVAL, RESET, CLEANUP};
    +
    +  /**
    +   * Field has 2 indexes within the constant pull: field item + name and 
type item.
    --- End diff --
    
    I missed the third index. Fixed estimation of max index value, thanks. Also 
added comment that explains the way, how it is calculating.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to