Github user parthchandra commented on a diff in the pull request:

    https://github.com/apache/drill/pull/826#discussion_r117076766
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
    @@ -160,6 +160,9 @@
       OptionValidator OUTPUT_FORMAT_VALIDATOR = new 
StringValidator(OUTPUT_FORMAT_OPTION, "parquet");
       String PARQUET_BLOCK_SIZE = "store.parquet.block-size";
       OptionValidator PARQUET_BLOCK_SIZE_VALIDATOR = new 
LongValidator(PARQUET_BLOCK_SIZE, 512*1024*1024);
    +  String PARQUET_WRITER_USE_CONFIGURED_BLOCK_SIZE = 
"store.parquet.writer.use_configured_block-size";
    --- End diff --
    
    This could be better named. The Parquet writer already uses the configured 
block size (the Parquet block size). You really want an option to create the 
file with the same HDFS block size as the Parquet row group for performance 
reasons. Why not name it to indicate that?  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to