Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/826#discussion_r117094528 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetRecordWriter.java --- @@ -380,14 +384,21 @@ public void endRecord() throws IOException { // since ParquetFileWriter will overwrite empty output file (append is not supported) // we need to re-apply file permission - parquetFileWriter = new ParquetFileWriter(conf, schema, path, ParquetFileWriter.Mode.OVERWRITE); + if (useConfiguredBlockSize) { + // Round up blockSize to multiple of 64K. + long writeBlockSize = ((long) ceil((double)blockSize/BLOCKSIZE_MULTIPLE)) * BLOCKSIZE_MULTIPLE; + // Passing writeBlockSize creates files with this blockSize instead of filesystem default blockSize. + // Currently, this is supported only by filesystems included in + // BLOCK_FS_SCHEMES (ParquetFileWriter.java in parquet-mr), which includes HDFS. + // For other filesystems, it uses default blockSize configured for the file system. + parquetFileWriter = new ParquetFileWriter(conf, schema, path, ParquetFileWriter.Mode.OVERWRITE, writeBlockSize, 0); + } else { + parquetFileWriter = new ParquetFileWriter(conf, schema, path, ParquetFileWriter.Mode.OVERWRITE); --- End diff -- This breaks previous behaviour. If a user had previously changed the parquet block size, they will not get Parquet RowGrougs of that size, but will get the default 512MB
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---